CI - Test spacetimedb-update self-install
#2637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
… bfops/release-ci
jdetter
reviewed
Apr 18, 2025
jdetter
previously approved these changes
Apr 18, 2025
Collaborator
jdetter
left a comment
jdetter
left a comment
There was a problem hiding this comment.
When you get the CI figured out this LGTM, thanks Zeke! :)
jdetter
reviewed
Apr 19, 2025
jdetter
approved these changes
Apr 19, 2025
Collaborator
jdetter
left a comment
jdetter
left a comment
There was a problem hiding this comment.
This seems fine to me, thanks Zeke 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Main change details
We recently had some breakage in our install flow. This PR adds a CI job that runs
spacetimedb-update self-install, which is similar to what happens in our new install process.This isn't a perfect mirror of our install process, which renames the binary to
spacetime-install/spacetime-install.exe, and then thespacetimedb-updatebinary itself infers from that name that it should be runningself-install. Additionally, our install process uses--root-diron Windows but not on Linux. It's worth considering whether we should extend this job to more closely match our exact install flow, but I'm trying to avoid letting the perfect be the enemy of the good here.We should make these checks required after this PR merges.
Other changes
As part of this PR, I also had to add some new plumbing to allow passing a
GITHUB_TOKENfor the API requests. See the inline comments for the reasoning. They're written in sweat and tears.API and ABI breaking changes
None.
Expected complexity level and risk
2
Testing