Fix error with the install script #2635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdetter
force-pushed
the
jdetter/fix-windows-error
branch
from
d40afd1 to
3a25dae
Compare
bfops
reviewed
Apr 18, 2025
jdetter
force-pushed
the
jdetter/fix-windows-error
branch
from
ee0fbad to
3b74319
Compare
Collaborator
|
I confirmed this works on Ubuntu as well with the explicit directory creation (i.e. it doesn't create |
2 tasks
This was referenced Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
We don't know why but since 1.0.1 the install script has not been creating the version directory.
API and ABI breaking changes
Not ABI/API breaking.
Expected complexity level and risk
The install process is currently broken and this will fix it.
Testing