Update rand #2568
Merged
Update rand #2568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
force-pushed
the
noa/upd-rand
branch
from
3282764 to
1c96f4f
Compare
Centril
approved these changes
Apr 10, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Follow-up to #2539, making it so core doesn't have 2 rand versions in the dependency tree. Because the
randfeature ofbindingsis specifically 0.8, I had to keep it as such, but semi-renamed it torand08, and we could add arand09flag in the future.randis hopefully soon-ish gonna settle it's API and maybe release 1.0, so I figured it's good to keep our dep tree on mostly the same version to prepare for that. The renaming of thebindingsfeature also lets us supportrand 0.9for bindings later in case there are users who are using that.Expected complexity level and risk
1 - straightforward update
Testing
n/a