Skip to content

Conversation

@coolreader18
Copy link
Collaborator

Description of Changes

Tungstenite 0.26 switches its Message to use Bytes instead of Vec<u8> for the payload, meaning we can now send messages without making a duplicate allocation for every client.

Expected complexity level and risk

2: updating a dependency, but it's pretty low risk.

Testing

n/a - general optimization

@coolreader18
Copy link
Collaborator Author

This pulls in rand 0.9 now, but I can make a followup to deduplicate that dependency.

@coolreader18 coolreader18 requested a review from Centril April 1, 2025 19:45
@Centril
Copy link
Contributor

Centril commented Apr 2, 2025

This pulls in rand 0.9 now, but I can make a followup to deduplicate that dependency.

Sounds good. Seems like zerocopy and other deps were duplicated as well, if you want to investigate in follow ups.

@coolreader18 coolreader18 force-pushed the noa/upd-tungstenite branch from 8e5cb27 to 2b4ea79 Compare April 2, 2025 17:44
@coolreader18 coolreader18 enabled auto-merge April 2, 2025 17:44
@coolreader18 coolreader18 added this pull request to the merge queue Apr 2, 2025
Merged via the queue into master with commit 649ce34 Apr 2, 2025
13 of 14 checks passed
@coolreader18 coolreader18 deleted the noa/upd-tungstenite branch April 8, 2025 19:40
@coolreader18 coolreader18 mentioned this pull request Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants