Remove standalone energy monitor. #2550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gefjon
approved these changes
Apr 4, 2025
Contributor
gefjon
left a comment
gefjon
left a comment
There was a problem hiding this comment.
Easy enough. I'll make a tracking ticket to purge all the now-dead code.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
kim
added a commit
that referenced
this pull request
Apr 16, 2025
PR #2550 removed performing the reducer call inside `spawn_blocking`, thereby introducing the regression to never invoke the `on_panic` callback. This causes a database to continue accepting writes even if it is unable to persist the transactions via its `Durability` impl. Instead, the `on_panic` callback should remove the database from the `HostController`, which renders _this_ database unavailable, but does not affect any other databases managed by the controller. The behavior is fine in `panic = abort` environments, yet until we have a better way to propagate durability errors as values to the `ModuleHost`, we can't abort the server in multi-tenant environments. Thus, restore the original behavior (using `spawn` instead of the more expensive `spawn_blocking`).
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The energy monitor has no use, and was removed in private a while ago. This change uses the
NullEnergyMonitor, so we don't do any work. Eventually we should purge all the energy monitor code.Expected complexity level and risk
1