commitlog: Streaming #2492
Merged
commitlog: Streaming #2492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to bypass `Commitlog::open` calls. `open` creates the initial segment if it doesn't exist, which can be undesirable.
Provide a `reset_to` free standing function, for when the `open` overhead is not needed.
kim
force-pushed
the
kim/commitlog/streaming
branch
from
b4d1dba to
e7cfeaa
Compare
Shubham8287
approved these changes
Mar 25, 2025
Contributor
|
Much needed consolidation! |
Adds machinery for reading and writing raw commitlog data in an (async) streaming fashion. Improves on the existing implementation by minimizing fsync calls, simplifying the API, and avoiding `tokio::task::block_in_place` calls. The latter is likely to improve throughput on densely provisioned servers.
kim
force-pushed
the
kim/commitlog/streaming
branch
from
caf9085 to
57693a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves support for streaming (network) transfer of raw commitlog data to the
commitlogcrate proper, along with some improvements.Also adds free-standing functions to determine the commitlog metadata and for
truncation. This allows to bypass
opening the commitlog in some cases, whichcan be both convenient and avoids implicit creation of a segment when the
commitlog is empty.
API and ABI breaking changes
None
Expected complexity level and risk
2
Complexity is in diffing against the previous implementation, which lives in a
different repo. Risk is zero, as the code is not used in a released version.
Testing
Adds tests.