Fix docker container for standalone #2289
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
We're going to merge this so that the docker-compose setup in this repository works again but we're going to be shipping a separate docker container for the website that uses all of the spacetimedb binaries (update, cli, standalone) instead of only standalone. This decision came from a conversation in discord with Tyler.
For those curious we're talking about the docker container described here: https://spacetimedb.com/install
Description of Changes
Binary split PR: #2011
Before the binary split the standalone command worked like this:
After the binary split we've changed it so that now the command needs to be composed like this:
You'll see that the arguments need to go after start instead of before it. This has broken the standalone docker container on the website. If you try it currently it looks like this:
Like I said, this is because
--data-dirno longer goes with thespacetimedb-standalonecommand but goes with thestartsubcommand instead.API and ABI breaking changes
If this is an API or ABI breaking change, please apply the
corresponding GitHub label.
Expected complexity level and risk
How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.
This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.
If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.
0 - this was broken before and it is fixed now. This didn't change our APIs or affect any other functionality, only the Dockerfile.
Testing
Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!
The docker container didn't work before but it works now.