-
Notifications
You must be signed in to change notification settings - Fork 664
Split binaries #2011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split binaries #2011
Conversation
e1cfc8b to
3c2be0c
Compare
3c2be0c to
699d806
Compare
|
Needs PR description according to template. |
|
PR description should include what the correct way for a reviewer to invoke the CLI is now. In the past I've been doing I also notice that you've updated the smoketests to invoke the inner |
d3fee57 to
302d7d2
Compare
gefjon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
|
I would ideally like to confirm that this has been tested on windows and mac before merging, but that feels out of scope for a codeowner review and @gefjon's already approved. |
8e68a02 to
dbc3575
Compare
dbc3575 to
8ab5c1e
Compare
bfops
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The files I'm a codeowner for look great to me. Thanks for bearing with me @coolreader18.
Description of Changes
Resolves #1838
Adds a
spacetimedb-updatemulticall binary that proxies tospacetimedb-cli, and makesspacetime runcall out to thespacetimedb-standalonebinary instead of embedding the whole server in the cli. Functionality for theupdatebinary itself forthcoming in another PR.Expected complexity level and risk
3 - adds the proxy binary and changes how
runworks under-the-hood, but the deeper changes will come in the follow-up.Testing
Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!
spacetimedb-updateproxied to the cli binary.