Skip to content

Conversation

@Centril
Copy link
Contributor

@Centril Centril commented Feb 5, 2025

Description of Changes

Given:

insert(row);
commit();
update(row);

there is a bug in MutTxId::update where it doesn't elide the delete/insert pair, unlike MutTxId::insert.

This PR fixes the bug.

API and ABI breaking changes

Not yet.

Expected complexity level and risk

2, fairly local change.

Testing

The test_update_idempotent test is updated to assert the idempotence of TxData in this scenario.

@Centril Centril requested a review from gefjon February 5, 2025 19:31
Copy link
Contributor

@gefjon gefjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, test looks good, and I tested locally and verified that I don't see the issue any more. Thanks so much for your quick work!

@Centril Centril added this pull request to the merge queue Feb 5, 2025
Merged via the queue into master with commit 25d7409 Feb 5, 2025
14 checks passed
@Centril Centril deleted the centril/fix-update-abi-idempotence branch February 5, 2025 21:01
bfops pushed a commit that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants