Make MutTxId::update really idempotent wrt. TxData
#2212
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Given:
there is a bug in
MutTxId::updatewhere it doesn't elide the delete/insert pair, unlikeMutTxId::insert.This PR fixes the bug.
API and ABI breaking changes
Not yet.
Expected complexity level and risk
2, fairly local change.
Testing
The
test_update_idempotenttest is updated to assert the idempotence ofTxDatain this scenario.