Implement new C# index syntax #2078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RReverser
force-pushed
the
ingvar/csharp-index-attr
branch
from
1c78277 to
8d54ff7
Compare
gefjon
approved these changes
Jan 7, 2025
- Changes index declarations to subclassing+namespacing as `[Index.BTree]` to better convey that you can't have multiple properties on the same index (e.g. when we add `Hash`, you can't do `[Index(BTree = ..., Hash = ...)]`. - Adds support for inline `[Index.BTree]` attributes on fields. - Adds various diagnostics for invalid index declarations. Marking as WIP because the proposal that specifies this syntax is in review for now - https://github.com/clockworklabs/SpacetimeDBPrivate/pull/1225 - and the syntax might still change.
RReverser
force-pushed
the
ingvar/csharp-index-attr
branch
from
8d54ff7 to
bc4930b
Compare
auto-merge was automatically disabled
January 7, 2025 21:10
Pull Request is not mergeable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Index.BTree]to better convey that you can't have multiple properties on the same index (e.g. when we addHash, you can't do[Index(BTree = ..., Hash = ...)].[Index.BTree]attributes on fields.Marking as WIP because the proposal that specifies this syntax is in review for now - https://github.com/clockworklabs/SpacetimeDBPrivate/pull/1225 - and the syntax might still change.
Fixes #2048.
Description of Changes
Please describe your change, mention any related tickets, and so on here.
API and ABI breaking changes
If this is an API or ABI breaking change, please apply the
corresponding GitHub label.
Expected complexity level and risk
How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.
This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.
If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.
Testing
Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!