[C#] Fix table view names and duplicate table registration #1757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RReverser
commented
Sep 28, 2024
crates/bindings-csharp/Codegen.Tests/fixtures/server/snapshots/Module#FFI.verified.cs
Outdated
Show resolved
Hide resolved
RReverser
commented
Sep 28, 2024
Comment on lines
55
to
60
| Columns: | ||
| [ | ||
| new(nameof(Name), BSATN.Name.GetAlgebraicType(registrar)), | ||
| new(nameof(Foo), BSATN.Foo.GetAlgebraicType(registrar)), | ||
| new(nameof(Bar), BSATN.Bar.GetAlgebraicType(registrar)) | ||
| ], |
Contributor
Author
There was a problem hiding this comment.
Nit for future work: we should be able to create and reuse this list instead of generating codegen for duplicates, as all table views have the same list of column names and types.
RReverser
force-pushed
the
ingvar/codegen-test-for-multi-tables
branch
from
72fdb7f to
420f15a
Compare
RReverser
changed the title
lcodes
reviewed
Sep 29, 2024
lcodes
approved these changes
Sep 29, 2024
In Codegen.Tests it's actually validated, snapshotted and checked that it compiles properly, whereas the SDK test runner doesn't do anything with the new folder since it doesn't match any existing Rust tests.
RReverser
force-pushed
the
ingvar/codegen-test-for-multi-tables
branch
from
fd85cd6 to
de5fa2a
Compare
RReverser
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
A follow-up to #1719.
In Codegen.Tests this test will be actually validated locally & on CI, snapshotted for reference, and checked that it compiles properly, whereas in that folder it was more or less dormant as the SDK test runner is intended only for tests that match pairwise between Rust/C# and doesn't know about the new folder.
This reveals at least one minor issue, but worth checking that there're no others.
API and ABI breaking changes
If this is an API or ABI breaking change, please apply the
corresponding GitHub label.
Expected complexity level and risk
How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.
This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.
If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.
Testing
Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!