Jeremie/cs module #1719
Merged
Jeremie/cs module #1719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RReverser
reviewed
Sep 18, 2024
Contributor
|
Just to duplicate a note from DMs - I noticed a few things in the PR that would be caught by the codegen tests, and looks like the snapshots haven't been updated in the PR. Can you please run Also #1718 might help with some attribute parsing here. |
RReverser
reviewed
Sep 18, 2024
RReverser
reviewed
Sep 18, 2024
RReverser
reviewed
Sep 18, 2024
lcodes
force-pushed
the
jeremie/cs-module
branch
from
a0c6f2b to
7180d99
Compare
RReverser
reviewed
Sep 23, 2024
RReverser
reviewed
Sep 23, 2024
RReverser
reviewed
Sep 23, 2024
RReverser
reviewed
Sep 23, 2024
RReverser
reviewed
Sep 23, 2024
RReverser
reviewed
Sep 23, 2024
RReverser
reviewed
Sep 23, 2024
RReverser
reviewed
Sep 23, 2024
RReverser
reviewed
Sep 23, 2024
RReverser
reviewed
Sep 24, 2024
RReverser
reviewed
Sep 24, 2024
RReverser
reviewed
Sep 24, 2024
RReverser
reviewed
Sep 24, 2024
RReverser
reviewed
Sep 24, 2024
RReverser
reviewed
Sep 24, 2024
lcodes
force-pushed
the
jeremie/cs-module
branch
from
adaac3d to
2ed0583
Compare
RReverser
reviewed
Sep 25, 2024
crates/bindings-csharp/Codegen.Tests/fixtures/server/snapshots/Module#PublicTable.verified.cs
Outdated
Show resolved
Hide resolved
RReverser
reviewed
Sep 25, 2024
RReverser
reviewed
Sep 25, 2024
RReverser
reviewed
Sep 25, 2024
RReverser
reviewed
Sep 25, 2024
lcodes
force-pushed
the
jeremie/cs-module
branch
from
c404b17 to
b5dfac7
Compare
RReverser
added a commit
that referenced
this pull request
Sep 27, 2024
A follow-up to #1719: - Hide `ColumnAttrs` and base `ColumnAttribute` classes into `SpacetimeDB.Internal` since they shouldn't be accessed by user. - Remove legacy `PrimaryKeyIdentity` alias as `ColumnAttrs` is no longer part of the public API. - Extend `ParseAs` helper to support abstract classes by accepting an explicit type. - Reuse `ParseAs` in couple of places instead of manual parsing. - Combine attributes by table early during parsing to reduce number of stored elements that need to be cached and iterated over. - Stringify ColumnAttrs as variant name again.
This was referenced Sep 27, 2024
RReverser
added a commit
that referenced
this pull request
Sep 28, 2024
I think it got missed in #1719. Migrated myself to the new API and added it to the solution.
RReverser
added a commit
that referenced
this pull request
Sep 28, 2024
I think it got missed in #1719. Migrated myself to the new API and added it to the solution.
2 tasks
RReverser
added a commit
that referenced
this pull request
Sep 28, 2024
I think it got missed in #1719. Migrated myself to the new API and added it to the solution.
Centril
pushed a commit
that referenced
this pull request
Sep 29, 2024
RReverser
added a commit
that referenced
this pull request
Sep 30, 2024
I think it got missed in #1719. Migrated myself to the new API and added it to the solution.
RReverser
added a commit
that referenced
this pull request
Sep 30, 2024
I think it got missed in #1719. Migrated myself to the new API and added it to the solution.
RReverser
added a commit
that referenced
this pull request
Sep 30, 2024
I think it got missed in #1719. Migrated myself to the new API and added it to the solution.
RReverser
added a commit
that referenced
this pull request
Sep 30, 2024
I think it got missed in #1719. Migrated myself to the new API and added it to the solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates runtime and codegen to support multiple tables per row type