Skip to content

Conversation

@SteveGibsonCL
Copy link
Contributor

Requires SDK PR #32
Requires / based on PR #12

Description of Changes

C# code is now generated with custom indexes for unique and primary fields

API

  • This is a breaking change to the module API
  • This is a breaking change to the ClientAPI

If the API is breaking, please state below what will break

@SteveGibsonCL SteveGibsonCL requested a review from jdetter June 22, 2023 20:26
@SteveGibsonCL SteveGibsonCL enabled auto-merge (squash) June 22, 2023 20:26
@SteveGibsonCL SteveGibsonCL changed the title Charp indexes Csharp indexes Jun 22, 2023
@jdetter jdetter mentioned this pull request Jun 26, 2023
2 tasks
Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performance is looking really good on this, awesome job @SteveBoytsun 👍

# Conflicts:
#	crates/cli/src/subcommands/generate/csharp.rs
#	crates/cli/tests/snapshots/codegen__codegen_output.snap
@SteveGibsonCL SteveGibsonCL merged commit aee3eb6 into master Jun 26, 2023
cloutiertyler added a commit that referenced this pull request Aug 1, 2023
* Changed C# reducer signature; Change reducer invocation method to return wether or not reducer has subscribers; Moved all ReducerEvent and ReducerArgs code into a single file

* Formatting, tests

* Clippy

* Removed union from C# codegen

* Tests

* Update crates/cli/src/subcommands/generate/csharp.rs

Co-authored-by: Tyler Cloutier <cloutiertyler@users.noreply.github.com>
Signed-off-by: John Detter <4099508+jdetter@users.noreply.github.com>

* Removed duplicate code

* Lint

* Clippy

* CLIPPY

* Generating custom indexes for unique / primary keys

---------

Signed-off-by: John Detter <4099508+jdetter@users.noreply.github.com>
Co-authored-by: Steve <steve@codefics.com>
Co-authored-by: John Detter <4099508+jdetter@users.noreply.github.com>
Co-authored-by: Tyler Cloutier <cloutiertyler@users.noreply.github.com>
cloutiertyler added a commit that referenced this pull request Aug 1, 2023
* Changed C# reducer signature; Change reducer invocation method to return wether or not reducer has subscribers; Moved all ReducerEvent and ReducerArgs code into a single file

* Formatting, tests

* Clippy

* Removed union from C# codegen

* Tests

* Update crates/cli/src/subcommands/generate/csharp.rs

Co-authored-by: Tyler Cloutier <cloutiertyler@users.noreply.github.com>
Signed-off-by: John Detter <4099508+jdetter@users.noreply.github.com>

* Removed duplicate code

* Lint

* Clippy

* CLIPPY

* Generating custom indexes for unique / primary keys

---------

Signed-off-by: John Detter <4099508+jdetter@users.noreply.github.com>
Co-authored-by: Steve <steve@codefics.com>
Co-authored-by: John Detter <4099508+jdetter@users.noreply.github.com>
Co-authored-by: Tyler Cloutier <cloutiertyler@users.noreply.github.com>
@cloutiertyler cloutiertyler deleted the charp-indexes branch August 1, 2023 21:56
bfops pushed a commit that referenced this pull request Jul 16, 2025
* Change Identity from UInt8Array to Identity to match other SDKs

* Fix typescript test

---------

Co-authored-by: Derek Brinkmann <dbrinkmann@citadelstudios.net>
bfops pushed a commit that referenced this pull request Jul 17, 2025
[DO NOT MERGE UNTIL NEW WEB DOCS RELEASED] Fix most (but possibly not all) links in the docs
bfops pushed a commit that referenced this pull request Jul 17, 2025
* Several updates to the way ClientCache + processing updates works

* Client cache changes working

* Removed log statements

---------

Co-authored-by: John Detter <no-reply@boppygames.gg>
bfops pushed a commit that referenced this pull request Aug 7, 2025
* Change Identity from UInt8Array to Identity to match other SDKs

* Fix typescript test

---------

Co-authored-by: Derek Brinkmann <dbrinkmann@citadelstudios.net>
bfops pushed a commit that referenced this pull request Aug 7, 2025
* Several updates to the way ClientCache + processing updates works

* Client cache changes working

* Removed log statements

---------

Co-authored-by: John Detter <no-reply@boppygames.gg>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants