-
Notifications
You must be signed in to change notification settings - Fork 664
Csharp indexes #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Csharp indexes #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urn wether or not reducer has subscribers; Moved all ReducerEvent and ReducerArgs code into a single file
Co-authored-by: Tyler Cloutier <cloutiertyler@users.noreply.github.com> Signed-off-by: John Detter <4099508+jdetter@users.noreply.github.com>
# Conflicts: # crates/cli/src/subcommands/generate/csharp.rs
jdetter
approved these changes
Jun 26, 2023
Collaborator
jdetter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Performance is looking really good on this, awesome job @SteveBoytsun 👍
# Conflicts: # crates/cli/src/subcommands/generate/csharp.rs # crates/cli/tests/snapshots/codegen__codegen_output.snap
cloutiertyler
added a commit
that referenced
this pull request
Aug 1, 2023
* Changed C# reducer signature; Change reducer invocation method to return wether or not reducer has subscribers; Moved all ReducerEvent and ReducerArgs code into a single file * Formatting, tests * Clippy * Removed union from C# codegen * Tests * Update crates/cli/src/subcommands/generate/csharp.rs Co-authored-by: Tyler Cloutier <cloutiertyler@users.noreply.github.com> Signed-off-by: John Detter <4099508+jdetter@users.noreply.github.com> * Removed duplicate code * Lint * Clippy * CLIPPY * Generating custom indexes for unique / primary keys --------- Signed-off-by: John Detter <4099508+jdetter@users.noreply.github.com> Co-authored-by: Steve <steve@codefics.com> Co-authored-by: John Detter <4099508+jdetter@users.noreply.github.com> Co-authored-by: Tyler Cloutier <cloutiertyler@users.noreply.github.com>
cloutiertyler
added a commit
that referenced
this pull request
Aug 1, 2023
* Changed C# reducer signature; Change reducer invocation method to return wether or not reducer has subscribers; Moved all ReducerEvent and ReducerArgs code into a single file * Formatting, tests * Clippy * Removed union from C# codegen * Tests * Update crates/cli/src/subcommands/generate/csharp.rs Co-authored-by: Tyler Cloutier <cloutiertyler@users.noreply.github.com> Signed-off-by: John Detter <4099508+jdetter@users.noreply.github.com> * Removed duplicate code * Lint * Clippy * CLIPPY * Generating custom indexes for unique / primary keys --------- Signed-off-by: John Detter <4099508+jdetter@users.noreply.github.com> Co-authored-by: Steve <steve@codefics.com> Co-authored-by: John Detter <4099508+jdetter@users.noreply.github.com> Co-authored-by: Tyler Cloutier <cloutiertyler@users.noreply.github.com>
bfops
pushed a commit
that referenced
this pull request
Jul 16, 2025
* Change Identity from UInt8Array to Identity to match other SDKs * Fix typescript test --------- Co-authored-by: Derek Brinkmann <dbrinkmann@citadelstudios.net>
bfops
pushed a commit
that referenced
this pull request
Jul 17, 2025
[DO NOT MERGE UNTIL NEW WEB DOCS RELEASED] Fix most (but possibly not all) links in the docs
bfops
pushed a commit
that referenced
this pull request
Jul 17, 2025
* Several updates to the way ClientCache + processing updates works * Client cache changes working * Removed log statements --------- Co-authored-by: John Detter <no-reply@boppygames.gg>
bfops
pushed a commit
that referenced
this pull request
Aug 7, 2025
* Change Identity from UInt8Array to Identity to match other SDKs * Fix typescript test --------- Co-authored-by: Derek Brinkmann <dbrinkmann@citadelstudios.net>
bfops
pushed a commit
that referenced
this pull request
Aug 7, 2025
* Several updates to the way ClientCache + processing updates works * Client cache changes working * Removed log statements --------- Co-authored-by: John Detter <no-reply@boppygames.gg>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires SDK PR #32
Requires / based on PR #12
Description of Changes
C# code is now generated with custom indexes for unique and primary fields
API
If the API is breaking, please state below what will break