-
Notifications
You must be signed in to change notification settings - Fork 664
Remove csharp union #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urn wether or not reducer has subscribers; Moved all ReducerEvent and ReducerArgs code into a single file
Co-authored-by: Tyler Cloutier <cloutiertyler@users.noreply.github.com> Signed-off-by: John Detter <4099508+jdetter@users.noreply.github.com>
# Conflicts: # crates/cli/src/subcommands/generate/csharp.rs
jdetter
approved these changes
Jun 26, 2023
Collaborator
jdetter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested via #14
auto-merge was automatically disabled
June 27, 2023 16:37
Pull request was closed
Contributor
Author
|
Merged with #14 |
bfops
pushed a commit
that referenced
this pull request
Jul 16, 2025
Added manual ws table connectors
bfops
pushed a commit
that referenced
this pull request
Jul 16, 2025
* Circle splitting and recombining; Client re-coloring * Renamed Entity.id into Entity.entity_id * Client refactor; Polish; Bugfixes * Store username between game runs * Renamed EntityActor.OnUpdate to OnEntityUpdate * [WIP] C# server * [WIP] C# server * Changed `DateTimeOffset` to `long` in C# module * Parallax background * Animate entities when they get consumed * Fixed respawn button * Draft into Steve's branch (#12) * Small changes * Changes to align with the tutorial. * Fixed rebase issue * Merged ConnectionManager and EntityManager into GameManager for tutorial simplicity * Renaming Actor -> Controller for simplicity's sake, although Actor is a good name * actor -> entityController * Merged ArenaController into GameManager for simplicity and cleaned up a few things * Small cleanup to keep it in line with the tutorial * Small changes to how overlapping works * Rebrand to Blackholio * Rebrand to Blackholio (missed one) * Added a README.md * fixed readme --------- Co-authored-by: Steve Gibson <steve@clockwokrlabs.io> Co-authored-by: Tyler Cloutier <cloutiertyler@users.noreply.github.com> Co-authored-by: Tyler Cloutier <cloutiertyler@aol.com>
bfops
pushed a commit
that referenced
this pull request
Jul 16, 2025
* Small changes * Changes to align with the tutorial. * Fixed rebase issue * Merged ConnectionManager and EntityManager into GameManager for tutorial simplicity * Renaming Actor -> Controller for simplicity's sake, although Actor is a good name * actor -> entityController * Merged ArenaController into GameManager for simplicity and cleaned up a few things * Small cleanup to keep it in line with the tutorial * Small changes to how overlapping works
bfops
pushed a commit
that referenced
this pull request
Jul 17, 2025
Co-authored-by: John Detter <no-reply@boppygames.gg>
bfops
pushed a commit
that referenced
this pull request
Aug 7, 2025
Co-authored-by: John Detter <no-reply@boppygames.gg>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires / contains PR #10
Description of Changes
Removed union from C#'s ReducerEvent as it seems to cause some instability
API
If the API is breaking, please state below what will break