fix(clerk-js): Avoid client updates on sign out

.changeset/thick-beds-beam.md

@@ -0,0 +1,5 @@
+---
+'@clerk/clerk-js': patch
+---
+
+Avoid client updates on sign out.

packages/clerk-js/src/core/resources/Base.ts

@@ -11,13 +11,15 @@ import { ClerkAPIResponseError, ClerkRuntimeError, Client } from './internal';
 export type BaseFetchOptions = ClerkResourceReloadParams & {
   forceUpdateClient?: boolean;
   fetchMaxTries?: number;
+  skipUpdateClient?: boolean;
 };
 
 export type BaseMutateParams = {
   action?: string;
   body?: any;
   method?: HTTPMethod;
   path?: string;
+  skipUpdateClient?: boolean;
 };
 
 function assertProductionKeysOnDev(statusCode: number, payloadErrors?: ClerkAPIErrorJSON[]) {
@@ -105,7 +107,7 @@ export abstract class BaseResource {
     }
 
     // TODO: Link to Client payload piggybacking design document
-    if (requestInit.method !== 'GET' || opts.forceUpdateClient) {
+    if ((requestInit.method !== 'GET' || opts.forceUpdateClient) && !opts.skipUpdateClient) {
       this._updateClient<J>(payload);
     }
 
@@ -180,8 +182,13 @@ export abstract class BaseResource {
   }
 
   protected async _baseMutate<J extends ClerkResourceJSON | null>(params: BaseMutateParams): Promise<this> {
-    const { action, body, method, path } = params;
-    const json = await BaseResource._fetch<J>({ method, path: path || this.path(action), body });
+    const { action, body, method, path, skipUpdateClient } = params;
+    let json;
+    if (skipUpdateClient) {
+      json = await BaseResource._fetch<J>({ method, path: path || this.path(action), body }, { skipUpdateClient });
+    } else {
+      json = await BaseResource._fetch<J>({ method, path: path || this.path(action), body });
+    }
     return this.fromJSON((json?.response || json) as J);
   }
 

packages/clerk-js/src/core/resources/Client.ts

@@ -91,6 +91,11 @@ export class Client extends BaseResource implements ClientResource {
   removeSessions(): Promise<ClientResource> {
     return this._baseDelete({
       path: this.path() + '/sessions',
+      /**
+       * Skipping updating the client matches the behaviour of `client.destroy`, which allows broadcasting a sign-out event,
+       * and delays emitting until `setActive` is called within `Clerk.signOut()`
+       */
+      skipUpdateClient: true,
     }).then(e => {
       SessionTokenCache.clear();
       return e as unknown as ClientResource;

packages/clerk-js/src/core/resources/Session.ts

@@ -71,6 +71,11 @@ export class Session extends BaseResource implements SessionResource {
     SessionTokenCache.clear();
     return this._basePost({
       action: 'remove',
+      /**
+       * Skipping updating the client matches the behaviour of `client.destroy`, which allows broadcasting a sign-out event,
+       * and delays emitting until `setActive` is called within `Clerk.signOut()`
+       */
+      skipUpdateClient: true,
     });
   };