fix(clerk-js): Avoid client updates on sign out #5204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3b63578 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
panteliselef
force-pushed
the
elef/sdki-886-avoid-early-emit-when-removing-sessions
branch
from
13d6f19 to
3b63578
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prior to long lived clients, we were calling client.destroy which will not cause
#emitto fire as part ofClerk.updateClient. Once long lived client got introduced, we started usingclient.removeSessions()which do update the client causing an early#emitto fire prior to the expectedsetActive.The problem
If an
<SignedIn/>RSC was used to wrap to protect some client side code that was blindly expectedsessionIdfromuseAuthto always be defined, it would break.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change