Skip to content

Conversation

@hoge2000
Copy link

@hoge2000 hoge2000 commented Jan 6, 2026

This PR adds complete Japanese localization for Path Copy Copy.

Changes:

  • Added 19 Japanese localization files for UI components (*.ja-JP.resx)
  • Added Japanese localization for Resources (Resources.ja-JP.resx)
  • Updated Resources.resx to include Japanese language entries

All files are saved as UTF-8 with BOM.

@clechasseur
Copy link
Owner

Nice work!

This seems to cover the Settings app. I assume you would also need to do translation for the Explorer extension and (possibly) the installer?

Also, were you able to test this locally? The workflows in the repo are apparently too out-of-date to run 🙁 I'll try to update them so we can at least build this.

Just as a warning, this project is not technically archived but I haven't really worked on it in many years. Were you able to build a localized Japanese version for yourself?

@hoge2000
Copy link
Author

hoge2000 commented Jan 6, 2026

Thank you for the quick response!

Regarding your questions:

  1. Explorer extension translation: Yes, I have also translated the Explorer extension (right-click context menu strings). I manually edited the PathCopyCopyLocalization_fr.dll file using Resource Hacker to create a Japanese version. However, I didn't include the .rc source files in this PR because I wanted to keep it simple and focused on the .resx files first. Would you like me to create the proper PathCopyCopyLocalization.ja source files (.rc, resource.h, .vcxproj) in a separate commit or PR?

  2. Installer translation: I haven't worked on the installer yet. Could you point me to the installer files that need translation?

  3. Local testing: I was not able to build the project locally due to the outdated workflows you mentioned. Instead, I tested the translation by:

    • Manually replacing the .resx files in an existing installation
    • Manually editing the .dll file for the Explorer extension
    • Verifying that the Japanese text displays correctly in both the Settings app and the right-click menu

I would be happy to provide the .rc source files for the Explorer extension if that would be helpful. I can also help with the installer translation once you point me to the relevant files.

Thank you for considering this contribution, and I understand the project's maintenance status. I'm willing to work with you to get this integrated properly.

@clechasseur
Copy link
Owner

@hoge2000 thanks. I think I fixed the workflow in default now - can you try updating your branch to see if they work now?

@hoge2000
Copy link
Author

hoge2000 commented Jan 8, 2026

Done! I've updated my branch by merging the latest 'default' branch.

I can see "Checks: 0" and "Workflow runs completed with no jobs" - I'm not sure if this means the workflow is working correctly or if there's still something that needs to be configured. Let me know if you need me to do anything else on my end.

Thank you for your help with this!

@clechasseur
Copy link
Owner

I can see "Checks: 0" and "Workflow runs completed with no jobs" - I'm not sure if this means the workflow is working correctly or if there's still something that needs to be configured. Let me know if you need me to do anything else on my end.

Because you are not (yet!) in the list of contributors to this repository, workflows in your PR require my approval. I've triggered the run, we'll see.

@hoge2000
Copy link
Author

hoge2000 commented Jan 8, 2026

Great! I can see "All checks have passed" now. Thank you for approving and triggering the workflow!

Please let me know if you need anything else from me regarding the Explorer extension (.rc files) or installer translation.

@hoge2000
Copy link
Author

Hi! Just checking in on this PR. I can see all checks have passed and there are no conflicts.

Is there anything else you need from me? I'm happy to:

  • Provide the .rc source files for the Explorer extension translation
  • Help with installer translation if needed
  • Make any other changes or additions you'd like

Thanks for your time and consideration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants