-
-
Notifications
You must be signed in to change notification settings - Fork 86
Add Japanese (ja-JP) localization #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: default
Are you sure you want to change the base?
Conversation
|
Nice work! This seems to cover the Settings app. I assume you would also need to do translation for the Explorer extension and (possibly) the installer? Also, were you able to test this locally? The workflows in the repo are apparently too out-of-date to run 🙁 I'll try to update them so we can at least build this. Just as a warning, this project is not technically archived but I haven't really worked on it in many years. Were you able to build a localized Japanese version for yourself? |
|
Thank you for the quick response! Regarding your questions:
I would be happy to provide the .rc source files for the Explorer extension if that would be helpful. I can also help with the installer translation once you point me to the relevant files. Thank you for considering this contribution, and I understand the project's maintenance status. I'm willing to work with you to get this integrated properly. |
|
@hoge2000 thanks. I think I fixed the workflow in |
|
Done! I've updated my branch by merging the latest 'default' branch. I can see "Checks: 0" and "Workflow runs completed with no jobs" - I'm not sure if this means the workflow is working correctly or if there's still something that needs to be configured. Let me know if you need me to do anything else on my end. Thank you for your help with this! |
Because you are not (yet!) in the list of contributors to this repository, workflows in your PR require my approval. I've triggered the run, we'll see. |
|
Great! I can see "All checks have passed" now. Thank you for approving and triggering the workflow! Please let me know if you need anything else from me regarding the Explorer extension (.rc files) or installer translation. |
|
Hi! Just checking in on this PR. I can see all checks have passed and there are no conflicts. Is there anything else you need from me? I'm happy to:
Thanks for your time and consideration! |
This PR adds complete Japanese localization for Path Copy Copy.
Changes:
All files are saved as UTF-8 with BOM.