Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use v2.0.0 deploy & pass docker build args #1058

Merged
merged 2 commits into from
Jul 11, 2024
Merged

use v2.0.0 deploy & pass docker build args #1058

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13ff888
use v2.0.0 deploy & pass docker build args
elrayle Jul 11, 2024
ce47ee1
add in tracking id
elrayle Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion .github/workflows/build-and-deploy-dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,23 @@ on:
branches: [master]

jobs:
upload-package-lock-json:
name: Upload package-lock.json from this repo
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4.1.1

- name: Upload package-lock.json
uses: actions/upload-artifact@v4
with:
name: package-lock.json
path: package-lock.json

build-and-deploy:
uses: clearlydefined/operations/.github/workflows/app-build-and-deploy.yml@v1.0.0
name: Build and Deploy
needs: upload-package-lock-json
uses: clearlydefined/operations/.github/workflows/app-build-and-deploy.yml@v2.0.0
secrets:
AZURE_CREDENTIALS: ${{ secrets.AZURE_CREDENTIALS }}
AZURE_WEBAPP_PUBLISH_PROFILE: ${{ secrets.AZURE_WEBAPP_PUBLISH_PROFILE_DEV }}
Expand All @@ -19,3 +34,6 @@ jobs:
application-type: ui
azure-app-base-name: clearlydefined
azure-app-name-postfix: -dev
docker-build-args: |
REACT_APP_SERVER="https://dev-api.clearlydefined.io"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elrayle " is not necessary here.

REACT_APP_GA_TRACKINGID="${{ secrets.REACT_APP_GA_TRACKINGID_DEV }}"