use v2.0.0 deploy & pass docker build args #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for blissful-goodall-fa23f6 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
qtomlinson
approved these changes
Jul 11, 2024
qtomlinson
reviewed
Jul 18, 2024
| @@ -19,3 +34,6 @@ jobs: | |||
| application-type: ui | |||
| azure-app-base-name: clearlydefined | |||
| azure-app-name-postfix: -dev | |||
| docker-build-args: | | |||
| REACT_APP_SERVER="https://dev-api.clearlydefined.io" | |||
There was a problem hiding this comment.
@elrayle " is not necessary here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1057
Description
The v2.0.0 deploy workflows support passing docker build args to the docker build. This fixes the problem where the
REACT_APP_SERVERarg to docker was not set. This was causing the website to communicate with the service at localhost:4000 instead of the expected dev.clearlydefined.io. The change also adds a new job to upload the package-lock.json file to the build artifacts. This is needed for the build-and-deploy job to be able to get the version from that file.Related Work