Stub out Virtualized Grid Example #326
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks to work for me. The only issue here is that the ordering seems to be unstable, if you drag and pause, the items shift. This does not happen if you keep the mouse 'wiggling'. Example below (gif):
|
peterhorne
reviewed
Sep 27, 2018
| cellRenderer={({columnIndex, key, rowIndex, style}) => { | ||
| const datumIndex = (rowIndex * COLUMN_COUNT) + columnIndex; | ||
|
|
||
| const {value, height} = items[datumIndex]; |
There was a problem hiding this comment.
This doesn't handle the case when datumIndex is greater than the number of items.
|
https://codesandbox.io/s/dazzling-rhodes-q6jku, a simple demo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @clauderic, I am trying to get this working with react-virtualized
<Grid>. I am running into an issue I'm hoping you can spot and address. In hopes of tempting you to help me out, I've stubbed out an illustrative example in the storybook demo page 😸 which I hope can be tweaked and added to the repo for future purposes.Basically, everything works, except that drag-scrolling down long distances generates errors in the console. The error is easy to reproduce. Run the demo locally, click on the . "Virtualized Grid" example, and drag scroll down, hard and fast. The error happens here:
https://github.com/clauderic/react-sortable-hoc/blob/master/src/SortableContainer/index.js#L681
I would be extremely grateful for a fix to this. Thanks for an awesome library.