-
Notifications
You must be signed in to change notification settings - Fork 62
chore: ⚡ Refactor script imports to local files and update package dependencies to resolve #37 #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…pendencies to resolve ckabalan#37
…paste the commands without worrying about the leading character.
|
@ckabalan Looking for Review on this and a pipeline approval. |
|
@ranma2913 - I've gone back and forth on whether to internalize these dependencies or not. Have you checked the license compatibility for each of these internalized dependencies to verify we can redistribute as part of our MIT Licensed project? I haven't checked, but if one of those licenses is more restrictive than MIT then we can't re-distribute their code as part of our project. However, we can link to THEIR distribution method and still release our project as MIT. If this doesn't introduce license issues I'd lean toward internalizing these. |
|
I can verify each license. I'll confirm here. |
|
@ckabalan every dependency is either Apache-2.0 or MIT |
|
@ckabalan just checking in. Is there anything else you would like me to look up? |
Summary
This PR refactors the application to eliminate external CDN dependencies by migrating to locally bundled JavaScript libraries. This change improves performance, reliability, and offline functionality while reducing external dependency risks.
Fixes #37
Changes Made
📦 CDN to Local Dependencies Migration
jquery: ^3.7.1jquery-validation: ^1.21.0node_modulestodist/js/🔧 Build Process Improvements
📚 Documentation Updates
>)Benefits
Migration Details
Before (CDN-based):
After (Local files):
Testing
Deployment Impact
✅ No breaking changes - The application maintains identical functionality while improving performance and reliability. The build process automatically handles dependency management.
This refactoring establishes a more robust foundation for the application by eliminating external dependencies while maintaining all existing functionality.