Skip to content

Conversation

@ranma2913
Copy link

Summary

This PR refactors the application to eliminate external CDN dependencies by migrating to locally bundled JavaScript libraries. This change improves performance, reliability, and offline functionality while reducing external dependency risks.

Fixes #37

Changes Made

📦 CDN to Local Dependencies Migration

  • Replaced CDN script imports with local file references in HTML files:
    • Bootstrap 5.3.6 JavaScript bundle
    • jQuery 3.7.1
    • jQuery Validation 1.21.0 (core + additional methods)
  • Updated package dependencies to include:
    • jquery: ^3.7.1
    • jquery-validation: ^1.21.0
  • Enhanced build script to automatically copy JavaScript dependencies from node_modules to dist/js/

🔧 Build Process Improvements

  • Automated dependency copying during build process
  • Added local JavaScript files to the repository for immediate availability
  • Maintained existing CSS compilation and other build steps

📚 Documentation Updates

  • Improved README commands by removing shell prompt characters (>)
  • Enhanced copy-paste experience for local development setup instructions
  • Streamlined command formatting for better user experience

Benefits

  1. Improved Performance: Eliminates network requests to external CDNs, reducing page load times
  2. Enhanced Reliability: Removes dependency on external CDN availability and network connectivity
  3. Offline Functionality: Application now works completely offline after initial download
  4. Security Enhancement: Reduces exposure to CDN compromise and supply chain attacks
  5. Version Control: All dependencies are now explicitly managed and versioned
  6. Development Experience: Faster local development with no external dependencies

Migration Details

Before (CDN-based):

<script src="https://cdn.jsdelivr.net/npm/bootstrap@5.3.6/dist/js/bootstrap.bundle.min.js" 
        integrity="sha384-j1CDi7MgGQ12Z7Qab0qlWQ/Qqz24Gc6BM0thvEMVjHnfYGF0rmFCozFSxQBxwHKO" 
        crossorigin="anonymous"></script>
<script src="https://code.jquery.com/jquery-3.7.1.min.js" 
        integrity="sha384-1H217gwSVyLSIfaLxHbE7dRb3v4mYCKbpQvzx0cegeju1MVsGrX5xXxAvs/HgeFs" 
        crossorigin="anonymous"></script>

After (Local files):

<script src="js/bootstrap.bundle.min.js"></script>
<script src="js/jquery.min.js"></script>
<script src="js/jquery.validate.min.js"></script>
<script src="js/additional-methods.min.js"></script>

Testing

  • Local development environment verified
  • Build process tested and working
  • All JavaScript functionality confirmed working with local files
  • Offline functionality validated
  • Documentation commands tested for copy-paste usability

Deployment Impact

No breaking changes - The application maintains identical functionality while improving performance and reliability. The build process automatically handles dependency management.

This refactoring establishes a more robust foundation for the application by eliminating external dependencies while maintaining all existing functionality.

@ranma2913
Copy link
Author

@ckabalan Looking for Review on this and a pipeline approval.

@ckabalan
Copy link
Owner

@ranma2913 - I've gone back and forth on whether to internalize these dependencies or not. Have you checked the license compatibility for each of these internalized dependencies to verify we can redistribute as part of our MIT Licensed project? I haven't checked, but if one of those licenses is more restrictive than MIT then we can't re-distribute their code as part of our project. However, we can link to THEIR distribution method and still release our project as MIT.

If this doesn't introduce license issues I'd lean toward internalizing these.

@ranma2913
Copy link
Author

I can verify each license. I'll confirm here.

@ranma2913
Copy link
Author

|% npx license-checker
├─ @playwright/test
│  ├─ licenses: Apache-2.0
│  ├─ repository: https://github.com/microsoft/playwright
│  ├─ publisher: Microsoft Corporation
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/@playwright/test
│  ├─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/@playwright/test/LICENSE
│  └─ noticeFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/@playwright/test/NOTICE
├─ @popperjs/core
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/popperjs/popper-core
│  ├─ publisher: Federico Zivolo
│  ├─ email: federico.zivolo@gmail.com
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/@popperjs/core
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/@popperjs/core/LICENSE.md
├─ @types/node
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/DefinitelyTyped/DefinitelyTyped
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/@types/node
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/@types/node/LICENSE
├─ ansi-styles@4.3.0
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/chalk/ansi-styles
│  ├─ publisher: Sindre Sorhus
│  ├─ email: sindresorhus@gmail.com
│  ├─ url: sindresorhus.com
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/ansi-styles
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/ansi-styles/license
├─ async@2.6.4
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/caolan/async
│  ├─ publisher: Caolan McMahon
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/async
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/async/LICENSE
├─ basic-auth@2.0.1
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/jshttp/basic-auth
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/basic-auth
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/basic-auth/LICENSE
├─ bootstrap@5.3.6
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/twbs/bootstrap
│  ├─ publisher: The Bootstrap Authors
│  ├─ url: https://github.com/twbs/bootstrap/graphs/contributors
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/bootstrap
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/bootstrap/LICENSE
├─ call-bind@1.0.7
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/ljharb/call-bind
│  ├─ publisher: Jordan Harband
│  ├─ email: ljharb@gmail.com
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/call-bind
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/call-bind/LICENSE
├─ chalk@4.1.2
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/chalk/chalk
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/chalk
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/chalk/license
├─ color-convert@2.0.1
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/Qix-/color-convert
│  ├─ publisher: Heather Arthur
│  ├─ email: fayearthur@gmail.com
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/color-convert
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/color-convert/LICENSE
├─ color-name@1.1.4
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/colorjs/color-name
│  ├─ publisher: DY
│  ├─ email: dfcreative@gmail.com
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/color-name
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/color-name/LICENSE
├─ corser@2.0.1
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/agrueneberg/Corser
│  ├─ publisher: Alexander Grüneberg
│  ├─ email: alexander.grueneberg@googlemail.com
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/corser
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/corser/LICENSE
├─ debug@3.2.7
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/visionmedia/debug
│  ├─ publisher: TJ Holowaychuk
│  ├─ email: tj@vision-media.ca
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/debug
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/debug/LICENSE
├─ define-data-property@1.1.4
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/ljharb/define-data-property
│  ├─ publisher: Jordan Harband
│  ├─ email: ljharb@gmail.com
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/define-data-property
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/define-data-property/LICENSE
├─ es-define-property@1.0.0
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/ljharb/es-define-property
│  ├─ publisher: Jordan Harband
│  ├─ email: ljharb@gmail.com
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/es-define-property
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/es-define-property/LICENSE
├─ es-errors@1.3.0
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/ljharb/es-errors
│  ├─ publisher: Jordan Harband
│  ├─ email: ljharb@gmail.com
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/es-errors
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/es-errors/LICENSE
├─ eventemitter3@4.0.7
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/primus/eventemitter3
│  ├─ publisher: Arnout Kazemier
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/eventemitter3
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/eventemitter3/LICENSE
├─ follow-redirects@1.15.9
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/follow-redirects/follow-redirects
│  ├─ publisher: Ruben Verborgh
│  ├─ email: ruben@verborgh.org
│  ├─ url: https://ruben.verborgh.org/
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/follow-redirects
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/follow-redirects/LICENSE
├─ fsevents@2.3.2
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/fsevents/fsevents
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/fsevents
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/fsevents/LICENSE
├─ function-bind@1.1.2
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/Raynos/function-bind
│  ├─ publisher: Raynos
│  ├─ email: raynos2@gmail.com
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/function-bind
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/function-bind/LICENSE
├─ get-intrinsic@1.2.4
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/ljharb/get-intrinsic
│  ├─ publisher: Jordan Harband
│  ├─ email: ljharb@gmail.com
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/get-intrinsic
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/get-intrinsic/LICENSE
├─ gopd@1.0.1
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/ljharb/gopd
│  ├─ publisher: Jordan Harband
│  ├─ email: ljharb@gmail.com
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/gopd
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/gopd/LICENSE
├─ has-flag@4.0.0
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/sindresorhus/has-flag
│  ├─ publisher: Sindre Sorhus
│  ├─ email: sindresorhus@gmail.com
│  ├─ url: sindresorhus.com
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/has-flag
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/has-flag/license
├─ has-property-descriptors@1.0.2
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/inspect-js/has-property-descriptors
│  ├─ publisher: Jordan Harband
│  ├─ email: ljharb@gmail.com
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/has-property-descriptors
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/has-property-descriptors/LICENSE
├─ has-proto@1.0.3
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/inspect-js/has-proto
│  ├─ publisher: Jordan Harband
│  ├─ email: ljharb@gmail.com
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/has-proto
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/has-proto/LICENSE
├─ has-symbols@1.0.3
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/inspect-js/has-symbols
│  ├─ publisher: Jordan Harband
│  ├─ email: ljharb@gmail.com
│  ├─ url: http://ljharb.codes
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/has-symbols
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/has-symbols/LICENSE
├─ hasown@2.0.2
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/inspect-js/hasOwn
│  ├─ publisher: Jordan Harband
│  ├─ email: ljharb@gmail.com
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/hasown
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/hasown/LICENSE
├─ he@1.2.0
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/mathiasbynens/he
│  ├─ publisher: Mathias Bynens
│  ├─ url: https://mathiasbynens.be/
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/he
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/he/LICENSE-MIT.txt
├─ html-encoding-sniffer@3.0.0
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/jsdom/html-encoding-sniffer
│  ├─ publisher: Domenic Denicola
│  ├─ email: d@domenic.me
│  ├─ url: https://domenic.me/
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/html-encoding-sniffer
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/html-encoding-sniffer/LICENSE.txt
├─ http-proxy@1.18.1
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/http-party/node-http-proxy
│  ├─ publisher: Charlie Robbins
│  ├─ email: charlie.robbins@gmail.com
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/http-proxy
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/http-proxy/LICENSE
├─ http-server@14.1.1
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/http-party/http-server
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/http-server
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/http-server/LICENSE
├─ iconv-lite@0.6.3
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/ashtuchkin/iconv-lite
│  ├─ publisher: Alexander Shtuchkin
│  ├─ email: ashtuchkin@gmail.com
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/iconv-lite
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/iconv-lite/LICENSE
├─ jquery-validation@1.21.0
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/jquery-validation/jquery-validation
│  ├─ publisher: Jörn Zaefferer
│  ├─ email: joern.zaefferer@gmail.com
│  ├─ url: http://bassistance.de
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/jquery-validation
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/jquery-validation/LICENSE.md
├─ jquery@3.7.1
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/jquery/jquery
│  ├─ publisher: OpenJS Foundation and other contributors
│  ├─ url: https://github.com/jquery/jquery/blob/3.7.1/AUTHORS.txt
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/jquery
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/jquery/LICENSE.txt
├─ lodash@4.17.21
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/lodash/lodash
│  ├─ publisher: John-David Dalton
│  ├─ email: john.david.dalton@gmail.com
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/lodash
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/lodash/LICENSE
├─ lz-string@1.5.0
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/pieroxy/lz-string
│  ├─ publisher: pieroxy
│  ├─ email: pieroxy@pieroxy.net
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/lz-string
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/lz-string/LICENSE
├─ mime@1.6.0
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/broofa/node-mime
│  ├─ publisher: Robert Kieffer
│  ├─ email: robert@broofa.com
│  ├─ url: http://github.com/broofa
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/mime
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/mime/LICENSE
├─ minimist@1.2.8
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/minimistjs/minimist
│  ├─ publisher: James Halliday
│  ├─ email: mail@substack.net
│  ├─ url: http://substack.net
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/minimist
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/minimist/LICENSE
├─ mkdirp@0.5.6
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/substack/node-mkdirp
│  ├─ publisher: James Halliday
│  ├─ email: mail@substack.net
│  ├─ url: http://substack.net
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/mkdirp
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/mkdirp/LICENSE
├─ ms@2.1.3
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/vercel/ms
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/ms
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/ms/license.md
├─ object-inspect@1.13.2
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/inspect-js/object-inspect
│  ├─ publisher: James Halliday
│  ├─ email: mail@substack.net
│  ├─ url: http://substack.net
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/object-inspect
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/object-inspect/LICENSE
├─ opener@1.5.2
│  ├─ licenses: (WTFPL OR MIT)
│  ├─ repository: https://github.com/domenic/opener
│  ├─ publisher: Domenic Denicola
│  ├─ email: d@domenic.me
│  ├─ url: https://domenic.me/
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/opener
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/opener/LICENSE.txt
├─ playwright-core@1.52.0
│  ├─ licenses: Apache-2.0
│  ├─ repository: https://github.com/microsoft/playwright
│  ├─ publisher: Microsoft Corporation
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/playwright-core
│  ├─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/playwright-core/LICENSE
│  └─ noticeFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/playwright-core/NOTICE
├─ playwright@1.52.0
│  ├─ licenses: Apache-2.0
│  ├─ repository: https://github.com/microsoft/playwright
│  ├─ publisher: Microsoft Corporation
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/playwright
│  ├─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/playwright/LICENSE
│  └─ noticeFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/playwright/NOTICE
├─ portfinder@1.0.32
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/http-party/node-portfinder
│  ├─ publisher: Charlie Robbins
│  ├─ email: charlie.robbins@gmail.com
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/portfinder
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/portfinder/LICENSE
├─ qs@6.13.0
│  ├─ licenses: BSD-3-Clause
│  ├─ repository: https://github.com/ljharb/qs
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/qs
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/qs/LICENSE.md
├─ requires-port@1.0.0
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/unshiftio/requires-port
│  ├─ publisher: Arnout Kazemier
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/requires-port
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/requires-port/LICENSE
├─ safe-buffer@5.1.2
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/feross/safe-buffer
│  ├─ publisher: Feross Aboukhadijeh
│  ├─ email: feross@feross.org
│  ├─ url: http://feross.org
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/safe-buffer
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/safe-buffer/LICENSE
├─ safer-buffer@2.1.2
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/ChALkeR/safer-buffer
│  ├─ publisher: Nikita Skovoroda
│  ├─ email: chalkerx@gmail.com
│  ├─ url: https://github.com/ChALkeR
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/safer-buffer
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/safer-buffer/LICENSE
├─ secure-compare@3.0.1
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/vdemedes/secure-compare
│  ├─ publisher: Vadim Demedes
│  ├─ email: vdemedes@gmail.com
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/secure-compare
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/secure-compare/README.md
├─ set-function-length@1.2.2
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/ljharb/set-function-length
│  ├─ publisher: Jordan Harband
│  ├─ email: ljharb@gmail.com
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/set-function-length
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/set-function-length/LICENSE
├─ side-channel@1.0.6
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/ljharb/side-channel
│  ├─ publisher: Jordan Harband
│  ├─ email: ljharb@gmail.com
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/side-channel
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/side-channel/LICENSE
├─ supports-color@7.2.0
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/chalk/supports-color
│  ├─ publisher: Sindre Sorhus
│  ├─ email: sindresorhus@gmail.com
│  ├─ url: sindresorhus.com
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/supports-color
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/supports-color/license
├─ undici-types@6.19.8
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/nodejs/undici
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/undici-types
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/undici-types/LICENSE
├─ union@0.5.0
│  ├─ licenses: MIT*
│  ├─ repository: https://github.com/flatiron/union
│  ├─ publisher: Charlie Robbins
│  ├─ email: charlie.robbins@gmail.com
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/union
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/union/LICENSE
├─ url-join@4.0.1
│  ├─ licenses: MIT
│  ├─ repository: https://github.com/jfromaniello/url-join
│  ├─ publisher: José F. Romaniello
│  ├─ email: jfromaniello@gmail.com
│  ├─ url: http://joseoncode.com
│  ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/url-join
│  └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/url-join/LICENSE
└─ whatwg-encoding@2.0.0
   ├─ licenses: MIT
   ├─ repository: https://github.com/jsdom/whatwg-encoding
   ├─ publisher: Domenic Denicola
   ├─ email: d@domenic.me
   ├─ url: https://domenic.me/
   ├─ path: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/whatwg-encoding
   └─ licenseFile: /Users/jsticha/WORK/RIPTiDE/IntelliJ_Workspace/visualsubnetcalc/src/node_modules/whatwg-encoding/LICENSE.txt

@ranma2913
Copy link
Author

@ranma2913 - I've gone back and forth on whether to internalize these dependencies or not. Have you checked the license compatibility for each of these internalized dependencies to verify we can redistribute as part of our MIT Licensed project? I haven't checked, but if one of those licenses is more restrictive than MIT then we can't re-distribute their code as part of our project. However, we can link to THEIR distribution method and still release our project as MIT.

If this doesn't introduce license issues I'd lean toward internalizing these.

@ckabalan every dependency is either Apache-2.0 or MIT

@ranma2913
Copy link
Author

@ckabalan just checking in. Is there anything else you would like me to look up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't load CDN js files while inside corporate network.

2 participants