-
Notifications
You must be signed in to change notification settings - Fork 62
chore: ✈ move static resources to src/static and cleanup build scripts & ✨ Resolve some issues ✨ #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…pendencies to resolve ckabalan#37
…paste the commands without worrying about the leading character.
0d64507 to
6da418c
Compare
…nd properly trim the clipboardData since copy-paste often has trailing whitespace.
… Use of Obsolete Functions. Change from `window.event` to modern `e.originalEvent.clipboardData`
|
@ckabalan Looking for Review on this and a pipeline approval. |
|
@bl4ckfir3 I see you made contributions this year. How did you engage @ckabalan for reviews? I'd like to ensure I'm following the best practice. |
… 404 (Not Found) (index):1 Error while trying to use the following icon from the Manifest: http://localhost:8080/icon/icon/android-chrome-192x192.png (Download error or resource isn't a valid image)
0f22969 to
c5bfd88
Compare
|
Hey @ranma2913 - The overview looks good and I would agree with all of those changes. I'll need to sit down and do some testing. I'm in the middle of moving my family across the US and will have to manage my time carefully. However, if it builds and the tests pass we should be in good shape. Give me some time to process this, I'm still committed to this project, but have to prioritize family for a little bit. |
|
You bet, it's a really useful project! I'm using it almost every week as I'm moving projects to public cloud from my company's datacenters. |
Summary
This PR refactors the project's build system and file organization to improve maintainability and align with modern web development practices. The changes reorganize static assets and modularize the build process.
Includes Commits from PR #41 so also fixes #37
Fixes #39
Fixes #42
Fixes #44
Fixes #45
Changes Made
🗂️ File Organization Restructure
dist/tosrc/static/including:index.html,404.html)favicon.ico,ads.txt,robots.txt,sitemap.xml)dist/directory.gitignoreto exclude thedist/directory from version control🔧 Build Script Improvements
process-sass: Compiles SCSS to CSScopy-js-deps: Copies JavaScript dependencies from node_modulescopy-static: Copies static assets fromsrc/static/todist/build: Orchestrates all build stepsnpx sassinstead of requiring global installationmkdir -pfor better reliability🐳 Docker Compliance Fix
Benefits
src/static/) and build output (dist/)src/static/and have them automatically copied during buildDeployment Impact
✅ No breaking changes - The deployment process remains unchanged:
npm run buildstill generates the completedist/directoryTesting
This refactoring sets up a more maintainable foundation for future development while ensuring zero disruption to the existing deployment infrastructure.