Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control installation of Python 2 via a role variable #46

Merged
merged 6 commits into from
Sep 28, 2022
Merged

Control installation of Python 2 via a role variable #46

merged 6 commits into from
Sep 28, 2022

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented May 18, 2022 •
edited
Loading

🗣 Description

This pull request modifies this role to control the installation of Python 2 via a role variable. Previously Python 2 was installed only on Debian Stretch.

Note that I have added the blocked label because this PR should be merged along with:

💭 Motivation and context

This change is part of the work that will allow us to build CyHy AMIs on top of on newer Debian releases.

🧪 Testing

All automated testing passes.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

@jsf9k jsf9k added blocked This issue or pull request is awaiting the outcome of another issue or pull request breaking change This issue or pull request involves changes to existing functionality improvement This issue or pull request will add or improve functionality, maintainability, or ease of use labels May 18, 2022
@jsf9k jsf9k self-assigned this May 18, 2022
@jsf9k jsf9k marked this pull request as ready for review May 18, 2022 20:12
dav3r
dav3r approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely! 💪 💼

mcdonnnj
mcdonnnj approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An excellent improvement. All I have are a couple of questions about packages.

vars/Amazon.yml Show resolved Hide resolved
vars/Debian_stretch.yml Show resolved Hide resolved
@jsf9k
Install necessary packages (where possible) to allow Ansible to use P…
7a80ed5 
…ython 2

Note that this can only be done for older Linux distributions such as
Amazon Linux 2, Debian Stretch, and Debian Buster.  This is because
Python 2 is well past EOL and therefore the necessary Python 2
packages do not exist in newer distributions.
@jsf9k jsf9k mentioned this pull request May 23, 2022
Merged
8 tasks
@jsf9k jsf9k mentioned this pull request May 24, 2022
Merged
9 tasks
jsf9k added a commit to cisagov/cyhy_amis that referenced this pull request May 24, 2022
@jsf9k
Temporarily use non-default branches of two Ansible roles
fd3c04a 
This change is being made for testing purposes, and will be reverted
after the following PRs are merged:
- cisagov/ansible-role-pip#50
- cisagov/ansible-role-python#46
jsf9k added a commit to cisagov/cyhy_amis that referenced this pull request May 24, 2022
@jsf9k
Temporarily use non-default branches of two Ansible roles
e27d1f1 
This change is being made for testing purposes, and will be reverted
after the following PRs are merged:
- cisagov/ansible-role-pip#50
- cisagov/ansible-role-python#46
jsf9k added a commit to cisagov/cyhy_amis that referenced this pull request May 25, 2022
@jsf9k
Temporarily use non-default branches of two Ansible roles
f91f32e 
This change is being made for testing purposes, and will be reverted
after the following PRs are merged:
- cisagov/ansible-role-pip#50
- cisagov/ansible-role-python#46
This was referenced Jun 7, 2022
Merged
Merged
Merged
Merged
Merged
@jsf9k jsf9k mentioned this pull request Jun 9, 2022
Merged
8 tasks
mcdonnnj pushed a commit to cisagov/cyhy_amis that referenced this pull request Jun 9, 2022
@jsf9k @mcdonnnj
Temporarily use non-default branches of two Ansible roles
ff00b0d 
This change is being made for testing purposes, and will be reverted
after the following PRs are merged:
- cisagov/ansible-role-pip#50
- cisagov/ansible-role-python#46
@jsf9k jsf9k mentioned this pull request Jun 10, 2022
Merged
8 tasks
jsf9k added a commit to cisagov/ansible-role-cyhy-feeds that referenced this pull request Jun 10, 2022
@jsf9k
Ensure that cisagov/cyhy-feeds is installed via Python 2
7121224 
Also ensure that this Ansible role works with the forthcoming code in
cisagov/ansible-role-python#46 and cisagov/ansible-role-pip#50.
jsf9k added a commit to cisagov/ansible-role-cyhy-feeds that referenced this pull request Jun 10, 2022
@jsf9k
Ensure that cisagov/cyhy-feeds is installed via Python 2
3221fdc 
Also ensure that this Ansible role works with the forthcoming code in
cisagov/ansible-role-python#46 and cisagov/ansible-role-pip#50.
jsf9k added a commit to cisagov/cyhy_amis that referenced this pull request Jun 23, 2022
@jsf9k
Temporarily use non-default branches of two Ansible roles
30d9f3c 
This change is being made for testing purposes, and will be reverted
after the following PRs are merged:
- cisagov/ansible-role-pip#50
- cisagov/ansible-role-python#46
mcdonnnj pushed a commit to cisagov/cyhy_amis that referenced this pull request Jul 20, 2022
@jsf9k @mcdonnnj
Temporarily use non-default branches of two Ansible roles
673c631 
This change is being made for testing purposes, and will be reverted
after the following PRs are merged:
- cisagov/ansible-role-pip#50
- cisagov/ansible-role-python#46
jsf9k added a commit to cisagov/cyhy_amis that referenced this pull request Sep 9, 2022
@jsf9k
Temporarily use non-default branches of two Ansible roles
5317152 
This change is being made for testing purposes, and will be reverted
after the following PRs are merged:
- cisagov/ansible-role-pip#50
- cisagov/ansible-role-python#46
@felddy felddy added this to the Summer CyHy AMI Spectacular milestone Sep 20, 2022
@mcdonnnj mcdonnnj merged commit d5df920 into develop Sep 28, 2022
@mcdonnnj mcdonnnj deleted the improvement/control-installation-of-python2-via-role-var branch September 28, 2022 23:57
@mcdonnnj mcdonnnj mentioned this pull request Sep 29, 2022
Closed
7 tasks
mcdonnnj pushed a commit to cisagov/cyhy_amis that referenced this pull request Oct 11, 2022
@jsf9k @mcdonnnj
Temporarily use non-default branches of two Ansible roles
aed2887 
This change is being made for testing purposes, and will be reverted
after the following PRs are merged:
- cisagov/ansible-role-pip#50
- cisagov/ansible-role-python#46
mcdonnnj pushed a commit to cisagov/cyhy_amis that referenced this pull request Oct 17, 2022
@jsf9k @mcdonnnj
Temporarily use non-default branches of two Ansible roles
8e5c369 
This change is being made for testing purposes, and will be reverted
after the following PRs are merged:
- cisagov/ansible-role-pip#50
- cisagov/ansible-role-python#46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@jsf9k jsf9k

@mcdonnnj mcdonnnj

Labels
blocked This issue or pull request is awaiting the outcome of another issue or pull request breaking change This issue or pull request involves changes to existing functionality improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
CyHy System
Status: Done
Milestone
Summer CyHy AMI Spectacular
Development

Successfully merging this pull request may close these issues.
4 participants
@jsf9k @dav3r @mcdonnnj @felddy