Update the supported platforms #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are making Python 2/pip2 support non-platform specific so we can expand the platforms we support. Comments that specify Debian Stretch have been updated accordingly.
With changes to the cisagov/ansible-role-python, cisagov/ansible-role-pip, and cisagov/ansible-role-remove-python2 projects we need to specify that we want to install Python 2/pip2 and that we do not want to remove Python 2.
Install the package directly with the pip module instead of downloading it on the host and installing from an extracted directory and ensure that it is installed with pip2. Also update testing to include checking for the apt packages we install.
Use the branches for cisagov/ansible-role-pip, cisagov/ansible-role-python, and cisagov/ansible-role-cyhy-core that support installation of Python 2/pip2 as a variable flag.
The host.pip_package class has been deprecated so we need to switch to the host.pip class. Additionally we should set the path for pip since we explicitly set it for the pip module in the role.
mcdonnnj
added
improvement
jsf9k
approved these changes
Jun 9, 2022
mcdonnnj
added
the
blocked
Since `docutils` is a dependency for `cyhy-commander` it should also be installed into the system Python 2 environment.
This reverts commit d857f5f. These branches have been merged into their respective develop branches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request updates the platforms supported by this Ansible role in addition to ensuring that the cyhy-commander package is installed with
pip2.⚠ Note
This pull request is reliant on the merge of the following:
💭 Motivation and context
We are in the process of updating the instances in cisagov/cyhy_amis to use Debian Buster for instances running Python 2 code. With the above mentioned PRs for Python/pip installation we can expand the supported platforms. Additionally we update the installation process so that the cyhy-commander package is installed directly with pip.
🧪 Testing
Automated tests pass.
✅ Pre-approval checklist
✅ Pre-merge checklist