Skip to content

Fixes Flutter git clone while Flutter 3.29.1 is not out #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2025
Merged

Fixes Flutter git clone while Flutter 3.29.1 is not out #362

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5066ddf
Fixes Flutter git clone while Flutter 3.29.1 is not out
davidmartos96 Mar 2, 2025
ef837da
redeploy
davidmartos96 Mar 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion sdk/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM ghcr.io/cirruslabs/android-sdk:34
FROM ghcr.io/cirruslabs/android-sdk:35

LABEL org.opencontainers.image.source=https://github.com/cirruslabs/docker-images-flutter
USER root
Expand All @@ -13,6 +13,11 @@ ENV PATH ${PATH}:${FLUTTER_HOME}/bin:${FLUTTER_HOME}/bin/cache/dart-sdk/bin

RUN git clone --depth 1 --branch ${FLUTTER_VERSION} https://github.com/flutter/flutter.git ${FLUTTER_HOME}

# Temporary workaround for https://github.com/flutter/flutter/issues/163308#issuecomment-2676366371
# It will be fixed in Flutter 3.29.1
# Removing this triggers fetching the correct Flutter engine version
RUN cd ${FLUTTER_HOME} && rm engine/src/.gn
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fkorotkov Is it still needed now? When 3.29.1 is out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.29.1 is available as a docker image. I believe this line sholdn't be required now with the new fixes


RUN yes | flutter doctor --android-licenses \
&& flutter doctor \
&& chown -R root:root ${FLUTTER_HOME}
Expand Down