Fixes Flutter git clone while Flutter 3.29.1 is not out #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkorotkov
approved these changes
Mar 3, 2025
|
Thank for working on this! |
BetterB0y
reviewed
Mar 7, 2025
| # Temporary workaround for https://github.com/flutter/flutter/issues/163308#issuecomment-2676366371 | ||
| # It will be fixed in Flutter 3.29.1 | ||
| # Removing this triggers fetching the correct Flutter engine version | ||
| RUN cd ${FLUTTER_HOME} && rm engine/src/.gn |
There was a problem hiding this comment.
@fkorotkov Is it still needed now? When 3.29.1 is out?
There was a problem hiding this comment.
3.29.1 is available as a docker image. I believe this line sholdn't be required now with the new fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for image building in Flutter 3.29 based on flutter/flutter#163308 (comment)
Also updated the android image from cirruslabs/docker-images-android#78