Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mdf performance and docs #1438

Merged
merged 10 commits into from
Feb 14, 2024
Merged

Mdf performance and docs #1438

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cdbf10e
Add benchmark for `NaiveDate::from_ymd`
pitdicker Feb 12, 2024
b8112c1
Add doc comments to `Mdf` methods
pitdicker Feb 13, 2024
8c5b02a
`Mdf::new`: remove checks that are also done by the table lookup
pitdicker Feb 13, 2024
71ac01e
Don't use `NaiveDate::from_ordinal_and_flags` in `from_mdf`
pitdicker Feb 13, 2024
2cdf733
Use `NonZeroI32::new_unchecked`
pitdicker Feb 13, 2024
6545c6f
Comparing against zero is slightly faster
pitdicker Feb 13, 2024
ad9727e
Casting a positive `i8` through `u8` is slightly faster
pitdicker Feb 13, 2024
8ecd0e9
Simplify test-only `Mdf::valid` method
pitdicker Feb 13, 2024
0393cca
`MAX_OL` and `MAX_MDL` can be private
pitdicker Feb 13, 2024
81a52a9
Extend `YearFlags` documentation/constants
pitdicker Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Comparing against zero is slightly faster
  • Loading branch information
@pitdicker
pitdicker committed Feb 14, 2024
commit 6545c6f03b489373dc3b371c0d20e23beeab3546
4 changes: 2 additions & 2 deletions src/naive/internals.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ pub(super) const MAX_MDL: u32 = (12 << 6) | (31 << 1) | 1;
// The next table are adjustment values to convert a date encoded as month-day-leapyear to
// ordinal-leapyear. OL = MDL - adjustment.
// Dates that do not exist are encoded as `XX`.
const XX: i8 = -128;
const XX: i8 = 0;
const MDL_TO_OL: &[i8; MAX_MDL as usize + 1] = &[
XX, XX, XX, XX, XX, XX, XX, XX, XX, XX, XX, XX, XX, XX, XX, XX, XX, XX, XX, XX, XX, XX, XX, XX,
XX, XX, XX, XX, XX, XX, XX, XX, XX, XX, XX, XX, XX, XX, XX, XX, XX, XX, XX, XX, XX, XX, XX, XX,
Expand Down Expand Up @@ -255,7 +255,7 @@ impl Mdf {
let mdl = mdf >> 3;
if mdl <= MAX_MDL {
// Array is indexed from `[1..=MAX_MDL]`, with a `0` index having a meaningless value.
MDL_TO_OL[mdl as usize] >= 0
MDL_TO_OL[mdl as usize] > 0
} else {
// Panicking here would be reasonable, but we are just going on with a safe value.
false
Expand Down