Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mdf performance and docs #1438

Merged
merged 10 commits into from
Feb 14, 2024
Merged

Mdf performance and docs #1438

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cdbf10e
Add benchmark for `NaiveDate::from_ymd`
pitdicker Feb 12, 2024
b8112c1
Add doc comments to `Mdf` methods
pitdicker Feb 13, 2024
8c5b02a
`Mdf::new`: remove checks that are also done by the table lookup
pitdicker Feb 13, 2024
71ac01e
Don't use `NaiveDate::from_ordinal_and_flags` in `from_mdf`
pitdicker Feb 13, 2024
2cdf733
Use `NonZeroI32::new_unchecked`
pitdicker Feb 13, 2024
6545c6f
Comparing against zero is slightly faster
pitdicker Feb 13, 2024
ad9727e
Casting a positive `i8` through `u8` is slightly faster
pitdicker Feb 13, 2024
8ecd0e9
Simplify test-only `Mdf::valid` method
pitdicker Feb 13, 2024
0393cca
`MAX_OL` and `MAX_MDL` can be private
pitdicker Feb 13, 2024
81a52a9
Extend `YearFlags` documentation/constants
pitdicker Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
MAX_OL and MAX_MDL can be private
  • Loading branch information
@pitdicker
pitdicker committed Feb 14, 2024
commit 0393ccab83f9fd821c9515a12f8fbbcb79c306a4
4 changes: 2 additions & 2 deletions src/naive/internals.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@ impl fmt::Debug for YearFlags {
}

// OL: (ordinal << 1) | leap year flag
pub(super) const MAX_OL: u32 = 366 << 1; // `(366 << 1) | 1` would be day 366 in a non-leap year
pub(super) const MAX_MDL: u32 = (12 << 6) | (31 << 1) | 1;
const MAX_OL: u32 = 366 << 1; // `(366 << 1) | 1` would be day 366 in a non-leap year
const MAX_MDL: u32 = (12 << 6) | (31 << 1) | 1;

// The next table are adjustment values to convert a date encoded as month-day-leapyear to
// ordinal-leapyear. OL = MDL - adjustment.
Expand Down