add tests for upsert and update with none ids

chroma-core · Sep 11, 2024 · bc71c6c · bc71c6c
1 parent b872676
commit bc71c6c
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/chromadb/test/api/test_api_update.py b/chromadb/test/api/test_api_update.py
@@ -0,0 +1,10 @@
+import pytest
+from chromadb.api import ClientAPI
+
+
+def test_update_with_none_ids(client: ClientAPI) -> None:
+    client.reset()
+    collection = client.create_collection("test")
+    with pytest.raises(ValueError) as e:
+        collection.update(ids=None, embeddings=[[0.1, 0.2, 0.3]])  # type: ignore[arg-type]
+    assert "You must provide ids." in str(e)
diff --git a/chromadb/test/api/test_api_upsert.py b/chromadb/test/api/test_api_upsert.py
@@ -0,0 +1,10 @@
+import pytest
+from chromadb.api import ClientAPI
+
+
+def test_upsert_with_none_ids(client: ClientAPI) -> None:
+    client.reset()
+    collection = client.create_collection("test")
+    with pytest.raises(ValueError) as e:
+        collection.upsert(ids=None, embeddings=[[0.1, 0.2, 0.3]])  # type: ignore[arg-type]
+    assert "You must provide ids." in str(e)