add id validations

chroma-core · Sep 11, 2024 · b872676 · b872676
1 parent cee4eab
commit b872676
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/chromadb/api/models/CollectionCommon.py b/chromadb/api/models/CollectionCommon.py
@@ -427,6 +427,9 @@ def _process_upsert_request(
             uris=uris,
         )
 
+        if unpacked_record_set["ids"] is None:
+            raise ValueError("You must provide ids.")
+
         self._validate_record_set(
             unpacked_record_set,
             require_data=True,
@@ -467,6 +470,9 @@ def _process_update_request(
             uris=uris,
         )
 
+        if unpacked_record_set["ids"] is None:
+            raise ValueError("You must provide ids.")
+
         self._validate_record_set(
             unpacked_record_set,
             require_data=False,