[LSP] Add TextDocumentEdit for textDocument/rename support. #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzeller
reviewed
Sep 28, 2024
common/lsp/lsp-protocol.yaml
Outdated
|
|
||
| TextDocumentEdit: | ||
| textDocument: OptionalVersionedTextDocumentIdentifier | ||
| edits: object # TextEdit[] |
There was a problem hiding this comment.
If you need an array of things and don't want it untyped, you can mark it with a plus to get a vector of TextEdit.
edits+: TextEdit
There was a problem hiding this comment.
LMK if you want to use the object version or change to TextEdit[] (with edits+:).
There was a problem hiding this comment.
No it sounds like a good idea and I hadn't realized the edits+ trick, sorry for the delay, should be able to push a new rev on Thurs.
There was a problem hiding this comment.
What is the status here ?
hzeller
reviewed
Oct 15, 2024
Via github UI Co-authored-by: Henner Zeller <h.zeller@acm.org>
hzeller
approved these changes
Oct 16, 2024
copybara-service bot
pushed a commit
to google/xls
that referenced
this pull request
Oct 16, 2024
By @cdleary in this PR chipsalliance/verible#2262 PiperOrigin-RevId: 686557188
|
Alright, updated dependency in XLS with google/xls@59c3390 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_rename
Result is
WorkspaceEditwhich prefersdocumentChangeswhich containTextDocumentEdit[]https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#workspaceEdit
(Note: we can do this with support for
changes?in the LSP but this is the suggested way for new implementations, so figured I'd add.)