Skip to content

Commit

Permalink
Use clang-tidy action to push comments to the PR.
Browse files Browse the repository at this point in the history
  • Loading branch information
hzeller committed Oct 8, 2024
1 parent 32b2456 commit 84b420d
Show file tree
Hide file tree
Showing 3 changed files with 59 additions and 0 deletions.
14 changes: 14 additions & 0 deletions .github/workflows/clang-tidy-post-comment.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
name: Post clang-tidy review comments

on:
workflow_run:
# The name field of the lint action .github/workflows/clang-tidy-run.yml
workflows: ["clang-tidy-review"]
types:
- completed

jobs:
PostClangTidyComments:
runs-on: ubuntu-latest
steps:
- uses: ZedThree/clang-tidy-review/post@v0.19.0
42 changes: 42 additions & 0 deletions .github/workflows/clang-tidy-run.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
name: clang-tidy-review

on:
pull_request:

jobs:
RunClangTidy:
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Create Cache Timestamp
id: cache_timestamp
uses: nanzm/get-time-action@v2.0
with:
format: 'YYYY-MM-DD-HH-mm-ss'

- name: Retrieve cached results
uses: actions/cache@v3
with:
path: |
/root/.cache/clang-tidy
/root/.cache/bazel
key: clang-tidy-${{ steps.cache_timestamp.outputs.time }}
restore-keys: clang-tidy-
- name: Make compilation DB
run: |
export USE_BAZEL_VERSION=6.5.0
.github/bin/make-compilation-db.sh
- name: Create clang-tidy review
uses: ZedThree/clang-tidy-review@v0.19.0
with:
split_workflow: true # Post comments separately
clang_tidy_version: 17
config_file: .clang-tidy

- uses: ZedThree/clang-tidy-review/upload@v0.19.0
3 changes: 3 additions & 0 deletions common/strings/obfuscator.cc
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ std::string Obfuscator::save() const {
absl::Status Obfuscator::load(absl::string_view mapping) {
const std::vector<absl::string_view> lines =
absl::StrSplit(mapping, '\n', absl::SkipEmpty());
// testing clang-tidy
BijectiveMap<std::string, std::string, StringViewCompare, StringViewCompare>
footesting;
for (const auto &line : lines) {
const std::vector<absl::string_view> elements =
absl::StrSplit(absl::StripAsciiWhitespace(line), kPairSeparator);
Expand Down

0 comments on commit 84b420d

Please sign in to comment.