Remove most Chisel Annotations #3723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature is being removed from Chisel 7: chipsalliance/chisel#4717 These custom annotations aren't used by `firtool`, so their removal doesn't impact that tool's outputs.
tymcauley
added a commit
to tymcauley/riscv-boom
that referenced
this pull request
Mar 7, 2025
tymcauley
added a commit
to tymcauley/cva6-wrapper
that referenced
this pull request
Mar 7, 2025
tymcauley
added a commit
to tymcauley/ibex-wrapper
that referenced
this pull request
Mar 7, 2025
tymcauley
added a commit
to tymcauley/rocket-chip
that referenced
this pull request
Mar 7, 2025
tymcauley
added a commit
to tymcauley/riscv-sodor
that referenced
this pull request
Mar 7, 2025
tymcauley
added a commit
to tymcauley/shuttle
that referenced
this pull request
Mar 7, 2025
tymcauley
added a commit
to tymcauley/chipyard
that referenced
this pull request
Mar 7, 2025
This was referenced Mar 7, 2025
jerryz123
approved these changes
Mar 7, 2025
tymcauley
added a commit
to tymcauley/chipyard
that referenced
this pull request
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #3722 (comment), this removes all Chisel annotations aside from
DCache's customInlineInstance. That will be handled in another PR.This needs to be coordinated with the following PRs to remove these APIs from other projects:
Related issue: #3722
Type of change: other enhancement
Impact: API modification
Development Phase: implementation
Release Notes