Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PTW Hypervisor bug fixes: check GPA bits higher than HGATP.Mode #3591

Merged
merged 4 commits into from
Mar 20, 2024

Conversation

ingallsj
Copy link
Contributor

@ingallsj ingallsj commented Mar 16, 2024

Related issue:

Type of change: bug report

Impact: functional fix

Development Phase: implementation

Release Notes

  1. The PTE Cache is supposed to cache the address being requested from memory.
  2. The RISC-V Privileged ISA spec states that, for every Stage-2 walk at every level of Stage-1 walk, we need to check

For Sv39x4, ... Address bits 63:41 must all be zeros, ...
For Sv48x4, ... Address bits 63:50 must all be zeros, ...
For Sv57x4, ... Address bits 63:59 must all be zeros, ...
or else a guest-page-fault exception occurs.

@ingallsj ingallsj marked this pull request as ready for review March 18, 2024 22:16
@ingallsj ingallsj requested a review from sequencer March 19, 2024 18:11
@ingallsj ingallsj merged commit dbcb06a into master Mar 20, 2024
26 checks passed
@ingallsj ingallsj deleted the hyp_ptw_gf branch March 20, 2024 21:58
@sequencer
Copy link
Member

we should add CI for Hypervisor in RocketChip. e.g. xvisor, kvm-riscv.
which testcases do you(@ingallsj @aswaterman) think, can be appropriate to add for testing?
I'll schedule someone to add these workloads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants