subsystem: update InterruptBusWrapper crossing code #2640
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
InterruptBusWrapper
in the following backwards-compatible ways:SimpleLazyModule with HasClockCrossings
IntXing
The beneficial effect beyond just modernization of APIs and more parameterizable crossing types is that the synchronization registers made by each crossing type will now be instantiated inside the
InterruptBusWrapper
hierarchically, each taking its clock and reset as their own. While in many cases the wrapper's clock and reset are the same as the subsystem clock and reset in which thefrom
methods are presumed to be called (e.g. by the peripherals'attachTo
methods), in certain cases these methods do get called inside some other scope. Thus this change should ensure that the synchronizing registers are always put in the destination clock domain, i.e. the one containing the InterruptBusWrapper and the PLIC, and not the hierarchy where the peripheral itself is attached.Type of change: feature request
Impact: API addition (no impact on existing code)
Development Phase: implementation
Release Notes
Synchronizers