Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLSourceShrinker: Preserve metadata when no shrinkage is required #2466

Merged
merged 3 commits into from
May 15, 2020

Conversation

hcook
Copy link
Member

@hcook hcook commented May 13, 2020

The TLSourceShrinker adapter circuitry becomes passthrough when it detects that the requested number of sources is larger than the actual number of sources used by the upstream topology. However, the adapter was still reporting the client metadata as if all clients had been combined together. Instead, we now more accurately preserve the client metadata information through the passthrough form of the adapter.

Type of change: other enhancement

Impact: API addition (no impact on existing code)

Development Phase: implementation

Release Notes

@hcook hcook requested a review from terpstra May 13, 2020 21:50
@hcook hcook merged commit a6848ee into master May 15, 2020
@hcook hcook deleted the no-shrink-required branch May 15, 2020 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants