public events field of EventSet and eventSets field of SuperscalarEve… #2464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntSets and apply hits of EventSet when EventSet is constructed, so events in EventSet and SuperscalarEventSets could be monitor
aswaterman
approved these changes
May 13, 2020
When evaluating EventSet.hits, event signals may not ready. change EventSet.hits to be Wire and evaluate in EventSet.check function, signals should be ready when EventSet.check is called
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
public events field of EventSet and eventSets field of SuperscalarEventSets
and apply hits of EventSet when EventSet is constructed,
so events in EventSet and SuperscalarEventSets could be monitor
Related issue:
Type of change: other enhancement
Impact: no functional change
Development Phase: implementation
Release Notes
** Purpose **
I am going to write a monitor for eventSets,
And I need to apply EventSet.hits whenever EventSet is instantiate because if I call EventSet.hits as a function in the monitor out of the scope it is instantiated, event lists in EventSet.events are not available.