Make the TLBroadcast and TLSourceShinker adapters pass through user bits #2446
Conversation
|
You've made this too complicated. You should not modify the parameters at all. All you needed to add was a 'user :<= in.user' and an 'out.user :<= in.user' ... and the same for echo. |
|
(I am assuming we want to forward the request permissions from the client onwards) |
|
In a real cache, it does not make sense to pass through the request since requests are merged. But here they are not. |
|
OTOH, maybe we want this? 🤷 |
|
@terpstra I think it makes sense to make both of these as transparent as possible for now. Another adapter to override or provide additional information could be inserted by user code. This produced the verilog signals I was expecting in my example, but can you re-review? |
hcook
changed the title
| echoFields = cp.echoFields, | ||
| requestFields = cp.requestFields, | ||
| responseKeys = cp.responseKeys | ||
| )}, |
There was a problem hiding this comment.
In contrast, you need it here b/c not copy.
|
👍 Minimal diff approved. |
|
In general, What does |
This change makes the
TLBroadcastandTLSourceShrinkertransparently pass through any user bits that are received from clients attached to them.