Remove unused type parameter on RegisterRouter. #2262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, I see the IO subclass having a |
terpstra
approved these changes
Feb 1, 2020
richardxia
deleted the
remove-unnecessary-type-parameter-on-register-router
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
Type of change: other enhancement
Impact: API modification (I guess this is technically backwards incompatible)
Development Phase: implementation
Release Notes
RegisterRouterno longer takes a type parameter, as it was not being used.I was trying to read the definition of
RegisterRouter, and I was having difficulty understanding what its type parameterT <: Datawas being used for. As far as I can tell, it is not being used by anything, and simply removing it and making it a non-generic type seems to work fine. If it is in fact actually being used for something, I'd love to learn more about it, since at my current level of understanding of Scala, I can't figure out how it is being used, since none of its members or methods depend on it.