Skip to content

Conversation

@trmckay
Copy link

@trmckay trmckay commented Dec 24, 2025

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

  • Support instantiation of SRAMs with read-latency and write-latency >= 1

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash) and clean up the commit message.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 24, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

Seq.fill(numReadPorts)(clock),
Seq.fill(numWritePorts)(clock),
Seq.fill(numReadwritePorts)(clock),
1,
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of the changes in this file:

  • Add readLatency and writeLatency to the private impl functions
  • For each public API
    • Set the default latency of 1
    • Add a copy of that method with latency parameters passed by the caller

If we expose additional parameters in the future, I think we can keep the minimal public APIs that were present before this PR, then add additional parameters to the new APIs added here.

@trmckay trmckay added the Feature New feature, will be included in release notes label Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature New feature, will be included in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant