Skip to content

Conversation

@chiselbot
Copy link
Collaborator

Found by @tymcauley ucb-bar/fixedpoint#11 (comment)

This bug was introduced 2 years ago when we added support for zero-width literals: #2932

The problem is that BigInt.bitlength excludes the sign bit, so we need to add 1 to it for SInts (which is what we originally did), BUT we need special case support for zero-width SInts (only when specified).

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash

Release Notes

For users attempting to reinterpret raw 2s complement values as SInts, use .U.asSInt.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash) and clean up the commit message.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

This is an automatic backport of pull request #4786 done by [Mergify](https://mergify.com).

Co-authored-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
(cherry picked from commit db93161)

# Conflicts:
#	src/test/scala/chiselTests/SIntOps.scala
@mergify mergify bot added Backport Automated backport, please consider for minor release bp-conflict labels Mar 12, 2025
@mergify
Copy link
Contributor

mergify bot commented Mar 12, 2025

Cherry-pick of db93161 has failed:

On branch mergify/bp/6.x/pr-4786
Your branch is up to date with 'origin/6.x'.

You are currently cherry-picking commit db931617.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   core/src/main/scala/chisel3/internal/firrtl/IR.scala

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/test/scala/chiselTests/SIntOps.scala

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions bot added the Bugfix Fixes a bug, will be included in release notes label Mar 12, 2025
@jackkoenig
Copy link
Contributor

Actually I don't want this backported. While it is technically a bug, there is code relying on this behavior that currently works a la ucb-bar/fixedpoint#11 (comment).

@jackkoenig jackkoenig closed this Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport Automated backport, please consider for minor release bp-conflict Bugfix Fixes a bug, will be included in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants