Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark return value of .asTypeOf as "deprecated read-only" (backport #4198) #4199

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 20, 2024

Users will now get a deprecation warning if they connect to the result of .asTypeOf.

Marked for backporting to 6.x so that we can change this in 7.0.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • API deprecation

Desired Merge Strategy

  • Squash

Release Notes

Previously, .asTypeOf would return a Wire. To get the old behavior, wrap the .asTypeOf call in WireInit(...).

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

This is an automatic backport of pull request #4198 done by [Mergify](https://mergify.com).

Users will now get a deprecation warning if they connect to the result
of .asTypeOf.

(cherry picked from commit 00c7a62)
@mergify mergify bot added the Backport Automated backport, please consider for minor release label Jun 20, 2024
@github-actions github-actions bot added the Deprecation Deprecates an API, will be included in release notes label Jun 20, 2024
@chiselbot chiselbot merged commit 0039ef0 into 6.x Jun 20, 2024
17 checks passed
@chiselbot chiselbot deleted the mergify/bp/6.x/pr-4198 branch June 20, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport Automated backport, please consider for minor release Deprecation Deprecates an API, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants