Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DontCare does not support Clocks #803

Open
colinschmidt opened this issue Mar 28, 2018 · 3 comments
Open

DontCare does not support Clocks #803

colinschmidt opened this issue Mar 28, 2018 · 3 comments
Assignees
Labels
bug code improvement feature request Feature New feature, will be included in release notes
Milestone

Comments

@colinschmidt
Copy link
Contributor

Type of issue: bug report | feature request

Impact: API modification

Development Phase: request

If the current behavior is a bug, please provide the steps to reproduce the problem:
Trying to connect a clock output to DontCare results in the following exception.

Caused by: chisel3.internal.ChiselException: cannot connect chisel3.core.Clock@1c9176 and chisel3.core.DontCare$@0

I would expect this to be supported. Its easy to work around by converting to/from Bool.
Is there a rationale for not support Clock or is it an oversight?

Please tell us about your environment:
chisel3 commit:

commit 10751f57c595c899b4bcb81a6b0f78319ca66eb2
Merge: dc20aa4 9fd9433
Author: Jim Lawson <ucbjrl@berkeley.edu>
Date:   Sun Mar 4 09:30:31 2018 -0800

    Merge branch '3.1.x' into 3.1.0
@azidar azidar added this to the 3.1.1 milestone Apr 20, 2018
@azidar
Copy link
Contributor

azidar commented Apr 20, 2018

This is an oversight. Will fix.

@edwardcwang edwardcwang modified the milestones: 3.1.1, 3.3.0 Jan 25, 2019
@edwardcwang edwardcwang added Feature New feature, will be included in release notes bug code improvement feature request labels Apr 27, 2019
@edwardcwang
Copy link
Contributor

Would like to second this. The workaround for val deadClock = Wire(Clock()); deadClock := DontCare is also a kludge:

      val w = Wire(Bool())
      w := DontCare
      val deadClock = Wire(Clock())
      deadClock := w.asClock

@ducky64
Copy link
Contributor

ducky64 commented Apr 27, 2019

Potentially related to the general connect semantics discussion in #1056 ?

@azidar azidar modified the milestones: 3.3.0, 3.4.x Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug code improvement feature request Feature New feature, will be included in release notes
Projects
None yet
Development

No branches or pull requests

5 participants