Merge pull request #3988 from alainmarcel/alainmarcel-patch-1

Error out on unknown parameter override
chipsalliance · Sep 24, 2024 · 4d8ef9e · 4d8ef9e
2 parents fd8dcc0 + 3f61df4
commit 4d8ef9e
Show file tree

Hide file tree

Showing 8 changed files with 92 additions and 305 deletions.
diff --git a/include/Surelog/ErrorReporting/ErrorDefinition.h b/include/Surelog/ErrorReporting/ErrorDefinition.h
@@ -237,7 +237,7 @@ class ErrorDefinition {
     ELAB_USE_INTERFACE_AS_SIGNAL_TYPE = 538,
     ELAB_UNKNOWN_STRUCT_MEMBER = 539,
     ELAB_UNKNOWN_INTERFACE_MEMBER = 540,
-    ELAB_UNKNOWN_PARAMETER = 541,
+    ELAB_UNKNOWN_PARAMETER_COMMAND = 541,
     ELAB_EXPRESSION_LOOP = 542,
     ELAB_SKIPPING_BLACKBOX_MODULE = 543,
     ELAB_SKIPPING_BLACKBOX_INSTANCE = 544,
@@ -248,6 +248,7 @@ class ErrorDefinition {
     ELAB_SYSTEM_INFO = 549,
     ELAB_UNKNOWN_PORT = 550,
     ELAB_TOP_PARAMETER_NO_DEFAULT = 551,
+    ELAB_UNKNOWN_PARAMETER_OVERRIDE = 552,
     LIB_FILE_MAPS_TO_MULTIPLE_LIBS = 600,
     UHDM_UNSUPPORTED_EXPR = 700,
     UHDM_UNSUPPORTED_STMT = 701,

diff --git a/src/DesignCompile/DesignElaboration.cpp b/src/DesignCompile/DesignElaboration.cpp
@@ -2023,6 +2023,18 @@ std::vector<std::string_view> DesignElaboration::collectParams_(
         // Named param
         const std::string_view name = parentFile->SymName(child);
         overridenParams.insert(name);
+        if (module) {
+          Parameter* p = module->getParameter(name);
+          if (p == nullptr) {
+            Location loc(parentFile->getFileId(paramAssign),
+                         parentFile->Line(paramAssign),
+                         parentFile->Column(paramAssign),
+                         st->registerSymbol(name));
+            Error err(ErrorDefinition::ELAB_UNKNOWN_PARAMETER_OVERRIDE, loc);
+            errors->addError(err);
+            continue;
+          }
+        }
         NodeId expr = parentFile->Sibling(child);
         if (!expr) {
           Location loc(
@@ -2523,7 +2535,7 @@ void DesignElaboration::checkElaboration_() {
       Location loc(
           m_compileDesign->getCompiler()->getSymbolTable()->registerSymbol(
               name));
-      Error err(ErrorDefinition::ELAB_UNKNOWN_PARAMETER, loc);
+      Error err(ErrorDefinition::ELAB_UNKNOWN_PARAMETER_COMMAND, loc);
       m_compileDesign->getCompiler()->getErrorContainer()->addError(err);
     }
   }

diff --git a/src/ErrorReporting/ErrorDefinition.cpp b/src/ErrorReporting/ErrorDefinition.cpp
@@ -419,7 +419,9 @@ bool ErrorDefinition::init() {
   rec(ELAB_UNKNOWN_INTERFACE_MEMBER, ERROR, ELAB,
       "Unknown interface member \"%s\"",
       "%exloc interface definition for \"%exobj\"");
-  rec(ELAB_UNKNOWN_PARAMETER, ERROR, ELAB,
+  rec(ELAB_UNKNOWN_PARAMETER_OVERRIDE, ERROR, ELAB,
+      "Unknown parameter override \"%s\"");
+  rec(ELAB_UNKNOWN_PARAMETER_COMMAND, ERROR, ELAB,
       "Unknown parameter in command line override \"%s\"");
   rec(ELAB_EXPRESSION_LOOP, ERROR, ELAB, "Expression loop in instance \"%s\"");
   rec(ELAB_SKIPPING_BLACKBOX_MODULE, INFO, ELAB,