-
Notifications
You must be signed in to change notification settings - Fork 676
Allow empty parentSelector #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow empty parentSelector #244
Conversation
02c1987
to
913e2a7
Compare
When this fix is merged into master?? Actualy this commit can fix this: angular-ui/ui-router#2260 and #239 ? |
I have resolved the issue caused by the parentSelector implementation in pull 272. Feel free to pull from me. |
merged in #272 |
Honestly, I don't think #272 actually resolves the issue this PR is about. |
@stefanotorresi querySelector doesn't have great support in older IEs, which I still have an obligation to support. |
Correct me if I'm wrong, but |
@chieffancypants, out of curiosity how far back are you having to support? My company just recently moved from IE8 to current (adding Chrome & FF) ... finally. |
@stefanotorresi Yes, technically, but with work, you can get the 1.2 branch to work with IE8, which is what I've been doing. Perhaps we could rewrite the PR to use querySelector if available, that way assholes like myself supporting shitty browsers can still use @jklaus: We're still IE8. This should change very soon though, since MS has dropped support for it. My customers are all large enterprises, so they inevitably refuse to upgrade even when there is significant pressure to do so. |
@chieffancypants all right then, I'll update the PR right away to make it more old-browser friendly :) |
92a462f
to
94fe2cd
Compare
@chieffancypants approve? |
Allow empty parentSelector
This patch builds on #218, which supersedes, because it wasn't handling all the cases.
This fixes #239, angular-ui/ui-router#2260 and #179 by appending the bar to the body tag when the specified selector (if any) is not available. The check happens when
start()
is invoked, so as soon as the selector is ready it will be used, without involving$timeout
or such things.