Problem with loading-bar

[furyscript]

Loading-bar works fine, but when I pass throgh a state that doesn't have the "container" of loading bar, I got this error

::::::::::::LOADING BAR START::::::::::::
angular.js:11607 TypeError: Cannot read property 'lastChild' of undefined
    at Object.e [as start] (loading-bar.min.js:7)
    at app.js:149
    at angular.js:16223
    at completeOutstandingRequest (angular.js:4905)
    at angular.js:5285(anonymous function) @ angular.js:11607$get @ angular.js:8557(anonymous function) @ angular.js:16226completeOutstandingRequest @ angular.js:4905(anonymous function) @ angular.js:5285
app.js:158
 ::::::::::::LOADING BAR END::::::::::::

On line 214 of angular-loading-bar you need to test if $parent[0] exist!
It occurs when I change state that doens't have selector div..

[hussainb]

Facing the same issue here. It happens intermittently and only on the first time of app load. And due to the error, the app fails in the initialization process.

Currently added a workaround: if (includeBar && $parent[0]) and if (includeSpinner && $parent[0])

[furyscript]

Yes, @chieffancypants commit bug fix :)

[chieffancypants]

What are you guys passing in as the parent container? By default it uses body, which I figured would exist everywhere. Do you guys not have a body tag in your html?

[furyscript]

Yes, I have "body" tag in my html, check the code maybe there is an issue ;) when you fix can you tell here the fix? :)

PS I use $state to change route (ui-route) so, where isn't the container I got error :)

[furyscript]

News ?:) @chieffancypants

[chieffancypants]

I don't use ui-router so I can't help you there. I'm happy to accept PRs, but I only do OSS in my spare time, and I'm not personally affected by this bug, so if you want it fixed quickly, please submit a PR, thanks!

Also, would be faster if I could see what the issue is. I am not affected by this bug, so please submit a plunker or fiddle that demonstrates the problem

[furyscript]

This is what I do to workaround the error

        if (includeBar && parent[0]) {
          $animate.enter(loadingBarContainer, $parent, angular.element($parent[0].lastChild));
        }

        if (includeSpinner && parent[0]) {
          $animate.enter(spinner, $parent, angular.element($parent[0].lastChild));
        }

At line between 205 and 215

[IvanGarzon]

Hi @chieffancypants are you able to commit this fix? it actually works I tested already and it seems to work properly the thing is that I am using bower to get the latest repository so could you please to commit this? thanks in advance...

[furyscript]

Can you commit this fix? @chieffancypants

[furyscript]

No commit from master about that?

[juliancuni]

@furyscript Thanks for the tip.

[furyscript]

It would be nice if some pull requests like #244 are been merged... @juliancuni So it resolve that issue :P

[juliancuni]

I am in a situation like - "Don't find fault, find remedy". Your tip saved my debug log being spammed by this module. However, I will trace this issue later on. Again thanks @furyscript

[furyscript]

No problem but I'm using bower and when I update this module the issue reappears :) no problem, good luck! @juliancuni