-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/bb post webhooks #694
Feature/bb post webhooks #694
Conversation
…99/cx-flow into feature/bb_post_webhooks
…99/cx-flow into feature/bb_post_webhooks
Hi @nleach999 , to run the full pipeline for the PR, the source branch needs to be created from the same repo (cxflow) and the branch name should start with 'pr-'. |
@MithileshPawar I don't have permissions to create a branch under checkmarx-ltd repos. You'll probably have to do what Ken did for my last PR that originated from my repo by re-targeting this PR and merging it to a branch that meets the naming criteria. |
Hi, @nleach999, looks like there are some conflicts. Can you try to rebase your branch (nleach999:feature/bb_post_webhooks) with the new base branch (pr-nathan-bitbucket-post-webhooks) ? |
…to feature/bb_post_webhooks
@MithileshPawar done, currently shows no conflicts. |
Description
Implementation of BitBucket Server third party webhook plugin Post Web Hooks resolves #651. Embedded wiki files have been updated to reflect the change. As part of the implementation, this fixes #650 to avoid additional scans by handling the MERGED event.
As part of the customer's deployment, they needed to have the ability to use multiple instances of BitBucket server to test the configuration and workflow before using in their production instance. As such, this resolves #674 with changes that allow for multiple BitBucket servers. The implementation may need some work given when looking at the multi-SCM feature, it was written to accommodate GitHub/GitLab type configurations where there is a URL for the SCM and a URL for the API. Since BitBucket uses one URL for the SCM and an additional "api-path" configuration, the "optional-instances" clause is configured differently to make multi-SCM with BBS work.
UPDATE: Also resolves #699 out of necessity for deployment.
Testing
Multi-SCM testing was done with a BB Server as the primary instance, a BB Server and BB Cloud as secondary instances. Issue #675 will remain open until testing is performed with BB Cloud as the primary SCM with one or more BB Servers as secondary.
Currently it is deployed and functional at a customer site with their production BB Server as the primary and their sandbox BB Server as the secondary.
The Post Web Hook plugin was also tested locally using BB Server and is in the customer's environment. Locally I validated that Post Web Hook events and BB Server native events were handled with no changes from the handling of the BB Server native events.
Post Web Hook global events are configured in the customer's sandbox and is being used in combination with config-as-code to provide override configurations on a per-repository basis. Per-repository Post Web Hook events were tested in my local setup. The customer has native BB Server events coming from their production instance, so CxFlow is handling both without issue.
Tested issue #699 with both Jira Data Center and Jira Cloud.
Checklist