Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for config-as-code broken for BB server push events (#481) #482

Merged
merged 1 commit into from
Oct 24, 2020

Conversation

kmcdon83
Copy link
Contributor

Description

A key/value pair in "additionalMetadata" was not being set before checking for config-as-code file in the BB Server repository.

References

Fixes #480

Testing

Performed a push event using BB server to verify it will consume the c-a-c file.

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable). If documentaiton is a Wiki Update, please indicate desired changes within PR MD Comment
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

* Fix for BB server push events using config as code
@kmcdon83
Copy link
Contributor Author

@fyi @nleach999 - I moved to a branch that starts with pr-* so that our entire pipeline runs.

@kmcdon83 kmcdon83 requested a review from AvivCx October 23, 2020 17:50
@sonarcloud
Copy link

sonarcloud bot commented Oct 23, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_265) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@AvivCx AvivCx added the bug Something isn't working label Oct 24, 2020
@AvivCx AvivCx merged commit 17eff33 into develop Oct 24, 2020
@kmcdon83 kmcdon83 deleted the pr-ts-fix/bb-config-as-code branch November 10, 2020 02:50
@nleach999 nleach999 mentioned this pull request Apr 1, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config-as-code broken in BitBucket server push events
3 participants