Skip to content

handle classic emails as such only in classic profiles #6767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2025
Merged

handle classic emails as such only in classic profiles #6767

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba78bd0
handle classic emails as such only in classic profiles
r10s Apr 3, 2025
c9618c1
tweak comment
r10s Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/receive_imf.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,8 +767,10 @@ async fn add_parts(
let allow_creation;
if mime_parser.is_system_message != SystemMessage::AutocryptSetupMessage
&& is_dc_message == MessengerMessage::No
&& !context.get_config_bool(Config::IsChatmail).await?
{
// this message is a classic email not a chat-message nor a reply to one
// the message is a classic email in a classic profile
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to comment on the reasoning here. Something along the lines of (in chatmail profiles, we always show all messages, because shared dc-mua usage is not supported)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i added the line.

at some point, we should really think about dropping these shared-usage-options alltogether ...

// (in chatmail profiles, we always show all messages, because shared dc-mua usage is not supported)
match show_emails {
ShowEmails::Off => {
info!(context, "Classical email not shown (TRASH).");
Expand Down
Loading