handle classic emails as such only in classic profiles #6767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So, the difference between a non-chatmail configuration with |
|
i do not know as well. maybe a bug. or reactions are not expected from classic mail inpractise but that question seems mostly unrelated |
Hocuri
approved these changes
Apr 4, 2025
| { | ||
| // this message is a classic email not a chat-message nor a reply to one | ||
| // the message is a classic email in a classic profile |
There was a problem hiding this comment.
Would be nice to comment on the reasoning here. Something along the lines of (in chatmail profiles, we always show all messages, because shared dc-mua usage is not supported)
There was a problem hiding this comment.
i added the line.
at some point, we should really think about dropping these shared-usage-options alltogether ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
next android/desktop/ios releases won't have the "Show Classic Emails" option for chatmail.
to avoid issues with user that have set sth else than "All", we ignore the option alltogether for chatmail profiles.
ftr, i do not expect ppl having that option changed for chatmail much, it does not make much sense. so this PR is mainly to save our limited support resources :) (usecase: "look, i am using chatmail to sign up at SERVICE, but for security reasons i set show=all only when i reset my password" :)
one could also do that in a migration, however, (a) migrations always come with some risk, even the easiest ones, and (b) the show_emails option is subject to change or disappear anyways, subsequent changes are easier in code than in additional or removed migrations, and (c) it is really only one line, that does not add much with complexity